ng-class can't apply css class to element

Question

I have this div somewhere in my code.

<div ng-class="className" >{{className}}</div>

At some point I am calling changeClass function from an ng-click to change the class of this div.

     $scope.changeClass = function(){
          console.log($scope.className)
              if ($scope.className === "expand-icon")
                 $scope.className = "expand-icon.expanded";
              else
                 $scope.className = "expand-icon";
  };

I can see the class changes because of the console.log and also the {{className}} is outputed on the page. However the css class doesn't seem to be applied.

It's in fact a '+' sign that needs to turn into a '-' with an animation. Here's the css:

 /* + button */

.expand-icon {
  height: 32px;
  width: 32px;
  position: relative;
}
.expand-icon::before, .expand-icon::after {
  content: " ";
  width: 32px;
  height: 6px;
  background-color: #fff;
  display: block;
  position: absolute;
  top: 50%;
  left: 50%;
  transition: all 0.15s cubic-bezier(.42, 0, .58, 1);
  opacity: 1;
  border-radius: 2px;
}
.expand-icon::before {
  transform: translate(-50%, -50%) rotate(90deg);
}
.expand-icon::after {
  transform: translate(-50%, -50%);
}

.expand-icon {
  height: 32px;
  width: 32px;
  position: relative;
}
.expand-icon.expanded::before {
  transform: translate(-50%, -50%) rotate(0deg);
}
.expand-icon.expanded::after {
  transform: translate(-50%, -50%) rotate(-90deg);
  opacity: 0;
}

So the expand-icon is applied but expand-icon.expanded doesn't have any affect since I'm using this ng-class trick. Any idea why?

You should replace the dot with a space: `$scope.className = "expand-icon expanded";` — devqon, Dec 15 '16 at 13:12
possible duplicate http://stackoverflow.com/questions/20460369/adding-and-removing-classes-in-angularjs-using-ng-click — Sa E Chowdary, Dec 15 '16 at 13:21

score 3 · Accepted Answer · answered Dec 15 '16 at 13:14

You should replace the dot with a space: $scope.className = "expand-icon expanded";

Or better, use the other notation of ng-class:

// probably rename it to something like $scope.toggleExpanded()
$scope.changeClass = function(){
    $scope.expanded = !$scope.expanded;
};

And in your html:

<div class="expand-icon"
     ng-class="{ expanded: expanded }">{{className}}</div>

This will apply your expand-icon class always, and the expanded class only when the $scope.expanded property is truthy.

score 0 · Answer 2 · answered Dec 15 '16 at 13:14

0

ng-class="className" is for expression. for example: ng-class="{classNam:true}".

in this case you can just do like this: class="{{className}}"

answered Dec 15 '16 at 13:14

vakho papidze

465
3
12

score 0 · Answer 3 · answered Dec 15 '16 at 13:15

0

Try this

<div class="{{className}}">{{className}}</div>

answered Dec 15 '16 at 13:15

Manoj Lodhi

978
4
10

ng-class can't apply css class to element

3 Answers3