recursive listing of directories

Question

I have the below code which has to do a recursive listing of all the files and directories. I am not sure if it is working fine.

#!/usr/bin/sh
recur_fun()
{
    for i in `ls -ltr | awk '{print $9}'` 
    do
        echo $i;
        cd $i;
        ls
        pwd
        recur_fun
        cd ..
        pwd
    done
}

recur_fun

I need to copy the name of the file and then use it in clearcase.

`for i in *` instead of `ls` and `awk`. – Dennis Williamson Nov 08 '10 at 05:00 — Dennis Williamson, Nov 08 '10 at 05:00

score 5 · Accepted Answer · answered Nov 08 '10 at 04:09

5

I suggest replacing this with:

find . -print

answered Nov 08 '10 at 04:09

Slartibartfast

1,694
9
8

i want to copy each file name into a variable and use it. – randeepsp Nov 08 '10 at 05:09
Just do a `for i in in $(find .); do whatever_you_want($i); done` – Noufal Ibrahim Nov 08 '10 at 05:46

score 3 · Answer 2 · answered Nov 08 '10 at 04:37

3

ls already has a recursive option:

ls -R

answered Nov 08 '10 at 04:37

too much php

88,666
34
128
138

score 2 · Answer 3 · edited May 23 '17 at 11:48

2

Note: I would rather recommend going with cleartool command than OS-specific shell commands.

For instance:

cleartool ls -r -nxn

would list all files recursively, private or not.
See Command line to delete all ClearCase view-private files for more.

edited May 23 '17 at 11:48

Community

1
1

answered Nov 08 '10 at 06:53

VonC

1,262,500
529
4,410
5,250

score 1 · Answer 4 · answered Nov 08 '10 at 04:41

If the purpose is to get the job done, then use pre-built tools such as 'find' or 'ls -R' to do the job reliably.

Assuming that the purpose is to learn about recursion and shell scripting, rather than to get the job done, then it is not working fine for a number of reasons:

It won't handle names with spaces in them.
When something isn't a directory, the cd will at best produce an error message.
At worst, if CDPATH is set and the name can be found on CDPATH, then the script is going to go haywire.
Because you don't check that the cd works, you're apt to see the same files listed over, and over, and over again (once per file in a given directory).

Additionally, the two semi-colons are superfluous.

If you do need to use cd in a script, it is usually a good idea to do that in sub-shell:

if [ -d $i ]
then ( cd $; pwd; recur_fun )
fi

When the sub-shell completes, you know the parent is still in exactly the same place it was in before - it doesn't depend on the vagaries of what the cd command does across symlinks. Modern shells (meaning bash) seem to think that you should normally want a 'logical cd' operation, which bugs the hell out of me because I almost never do want that behaviour.

Try `set -P` to cause Bash to do "physical" `cd`. – Dennis Williamson Nov 08 '10 at 04:58 — Dennis Williamson, Nov 08 '10 at 04:58

recursive listing of directories

recur_fun

4 Answers4