how to add a working button in a fragment?

Question

Hello im new in Android studio and tried to make a button working in a fragment but it doesnt work?

My Fragment code:

package layout;

import android.content.Context;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.support.design.widget.Snackbar;
import android.support.v4.app.Fragment;
import android.support.v4.widget.SearchViewCompat;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;   
import com.marcphi.csgoskin.R;
import com.marcphi.csgoskin.SkinListActivity;

public class NewsFragment extends Fragment implements View.OnClickListener {

    View view;
    Button btn;
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
                             Bundle savedInstanceState) {

        View view = inflater.inflate(R.layout.fragment_news, container, false);  
        btn = (Button) view.findViewById(R.id.button1);
        btn.setOnClickListener(this);         
        return  view;
    }
    public void onClick(View view){
        Snackbar.make(view, "Replace with your own action", Snackbar.LENGTH_LONG)
                .setAction("Action", null).show();
        Intent intent = new Intent(getActivity(), SkinListActivity.class);
        startActivity(intent);  
    }       
}

There is now Error on debugging .

post the complete code or you can google , set setOnClickListener in fragment — Pavneet_Singh, Dec 20 '16 at 16:54
"doesn't work" isn't an error.. post code or explain better. — Pier Giorgio Misley, Dec 20 '16 at 16:56
to display snackbar http://stackoverflow.com/questions/32305627/snackbar-is-not-working-within-fragment-class — Pavneet_Singh, Dec 20 '16 at 17:24

score 0 · Answer 1 · answered Dec 20 '16 at 18:01

One way to do this:

btn = (Button) view.findViewById(R.id.button1);
btn.setOnClickListener(new OnClickListener() {
            public void onClick(View v) {
                // Perform action on click   

                Snackbar.make(v, 
                              "Replace with your own action", 
                               Snackbar.LENGTH_LONG)
                         .setAction("Action", null).show();

                Intent intent = new Intent(getActivity(),
                                           SkinListActivity.class);
                startActivity(intent);  
            }
        });

score 0 · Answer 2 · edited Dec 20 '16 at 21:57

0

In your onClick method add:

If (view.getId() == R.id.button1) {
   // Here place code of onClick method
}

edited Dec 20 '16 at 21:57

OneCricketeer

179,855
19
132
245

answered Dec 20 '16 at 18:10

Polurival

58
1
9

score 0 · Answer 3 · answered Dec 20 '16 at 22:20

It doesnt work because Snackbar.make() takes coordinatorLayout as first argument and you are passing button in it.

If you want to use Snackbar you must use CoordinatorLayout as your rootView in your fragment and then pass it to Snackbar like this:

Snackbar.make(coordinatorLayout, "Replace with your own action", Snackbar.LENGTH_LONG)
            .setAction("Action", null).show();

how to add a working button in a fragment?

3 Answers3