C# Spam in output, how can i fix it?

Question

I want to make program in c# that will found value and show it in text box, but it's not a problem... When I tried to show this value, program spam in 1 text box, so it's impossible to read something.

    private void button1_Click(object sender, System.EventArgs e)
    {
        using (var client = new WebClient())
        {
            string input = client.DownloadString("example.com");
            textBox2.AppendText(input);
            Regex regex = new Regex("[^<b>](.*)[^</b>]", RegexOptions.IgnoreCase);
            Match match;
            for (match = regex.Match(input); match.Success; match = match.NextMatch())
            {
                foreach (Group group in match.Groups)
                {
                    textBox1.AppendText(string.Format("Value {0}", group));
                }
            }
        }
    }

1 Text box should show only the value
2 Text box show html code from page

Your regular expression is matching an awful lot more than you meant it to. `[^...]` defines a negative character class. — Phylogenesis, Dec 22 '16 at 17:21
I think your regular expression isn't doing what you want. Are you trying to find something like `This is bold text`, and then show just the text between `` and ``? — Jim Mischel, Dec 22 '16 at 17:36
Thank you Jim, u found my problem. I should correct regex pattern — MKKL, Dec 22 '16 at 17:53
@MKKL Parsing HTML with regex is a bad idea, you'd better try some HTML parser - http://stackoverflow.com/questions/56107/what-is-the-best-way-to-parse-html-in-c — Eugene Podskal, Dec 22 '16 at 18:41
I recommend to use HtmlAgilityPack for HTML parsing - https://www.nuget.org/packages/HtmlAgilityPack. — Viktors Telle, Dec 22 '16 at 18:57
Please do not use regex to parse HTML. You will awaken [the great devourer of worlds](http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags). — Guillaume CR, Dec 22 '16 at 19:54

score 0 · Answer 1 · answered Dec 22 '16 at 20:35

0

You can use CSQuery to parse your HTML:

https://github.com/jamietre/CsQuery

CQ dom = "<div>Hello world! <b>I am feeling bold!</b> What about <b>you?</b></div>";

string bold = dom["b"].First().InnerText;

You can select elements like JQuery

answered Dec 22 '16 at 20:35

Igor Quirino

1,187
13
28

C# Spam in output, how can i fix it?

1 Answers1