PHP not updating MySQL Table

Question

I am new to PHP and want to create a script that will update the users first and last name if they need to do so. I have the code below and it ends up echoing out UPDATE fixableusers SET first='trenton' WHERE id='6' on the settings.inc.php page but it is not updating the table. Is there a reason it is not updating the table?

<?php
include_once('dbh.php');

session_start();
$userSession = $_SESSION['id'];

if(isset($_SESSION['id'])) {
    $postTest = $_POST['first'];
    $sql = "UPDATE fixableusers SET first='$postTest' WHERE id='$userSession'";
} else {
    echo 'Do something else';
}

My dbh.php file includes the following code:

<?php

$conn = mysqli_connect('localhost', 'root', 'root', 'users');

please use prepared statements to fix your sql injection vunlerability ( malicious things passed in post ). There's no point in _not_ making a good habit starting _now_. — erik258, Dec 23 '16 at 03:26
http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php — erik258, Dec 23 '16 at 03:30

Naga · Accepted Answer · 2016-12-23T04:10:18.630

5

You are excluding the mysqli_query function,

Add this mysqli_query($conn, $sql); after build the $sql.

edited Dec 23 '16 at 04:10

answered Dec 23 '16 at 03:25

Naga

2,190
3
16
21

score 1 · Answer 2 · edited Dec 23 '16 at 03:28

1

Inside your if statement you're just declaring variables, in order to actually execute a query you need to :
if(isset($_SESSION['id'])) { $postTest = $_POST['first']; $sql = "UPDATE fixableusers SET first='$postTest' WHERE id='$userSession'"; mysqli_query($conn, $sql); }

And you need to improve this ( handle errors ..etc)

edited Dec 23 '16 at 03:28

answered Dec 23 '16 at 03:22

Taki

17,320
4
26
47

Karthik · Answer 3 · 2016-12-23T09:09:16.263

1

<?php
// Connect your DB
include_once('dbh.php');

//Start Session    
session_start();

if(isset($_SESSION['id'])) {

// Update Query
$updateqry = "UPDATE fixableusers SET first='".$_POST['first']."' WHERE id='".$_SESSION['id']."'";
mysqli_query($conn, $updateqry);

} else {

        echo 'Do something else';
}

?>

edited Dec 23 '16 at 09:09

answered Dec 23 '16 at 04:40

Karthik

5,589
18
46
78

1

Please add some explanation to the code so the OP and further readers can understand your code. The OP is a beginner and so are many others on this site. – beerwin Dec 23 '16 at 08:35

PHP not updating MySQL Table

3 Answers3