Parse error: syntax error, unexpected '{', expecting '(' in C:\xampp\htdocs\vft_forum\admin\admin_forum\poster.php on line 189

Question

i have got that error when trying to open my files after adding some line on on the file. here are my codes

if($topic=="WINDOWS"){?>

    <script>
        window.location = 'home.php';
    </script>   
<?php }elseif($topic=="MAC"){?>

    <script>
        window.location = 'mac.php';
    </script>   
<?php }elseif($topic=="LINUX"){?>

    <script>
        window.location = 'linux.php';
    </script>   
<?php }elseif($topic=="ANDROID"){?>

    <script>
        window.location = 'android.php';
    </script>   
<?php  }elseif($topic=="PROGRAMMING"){?>

    <script>
        window.location = 'program.php';
    </script>   
<?php }elseif($topic=="HARDWARE"){?>

    <script>
        window.location = 'hardware.php';
    </script>   
<?php }elseif($topic=="IOS"){?>

    <script>
        window.location = 'ios.php';
    </script>   
<?php }else {?>

    <script>
        window.location = 'msoffice.php';
    </script>   
<?php  } 
}?>

the error occurred on line that started with HARDWARE. I have tried to check but i couldint find that error. could some one help me with this? thanks in advance

to much lines in you code, you can write it cleaner and smarter. use http://php.net/manual/en/control-structures.switch.php . — Eugen, Jan 02 '17 at 12:18

score 2 · Answer 1 · edited Mar 06 '17 at 07:14

2

Have an '}' in the very end. Remove that.

edited Mar 06 '17 at 07:14

Alive to die - Anant

70,531
10
51
98

answered Jan 02 '17 at 12:14

Michael

405
4
10

Thanks a lot. but now im getting Parse error: syntax error, unexpected end of file – oedward38 Jan 02 '17 at 12:37
Sorry mate its my mistake i clicked on a wrong post. my apologies @Anant – oedward38 Mar 06 '17 at 07:12
@oedward38 then correct it. – Alive to die - Anant Mar 06 '17 at 07:14

Alive to die - Anant · Answer 2 · 2017-03-06T07:14:55.243

Suggestion:- use switch() cases instead of this much lines of code.

BTW properly formated code is:-

if($topic=="WINDOWS"){?>

    <script>
        window.location = 'home.php';
    </script>   
<?php }elseif($topic=="MAC"){?>

    <script>
        window.location = 'mac.php';
    </script>   
<?php }elseif($topic=="LINUX"){?>

    <script>
        window.location = 'linux.php';
    </script>   
<?php }elseif($topic=="ANDROID"){?>

    <script>
        window.location = 'android.php';
    </script>   
<?php  }elseif($topic=="PROGRAMMING"){?>

    <script>
        window.location = 'program.php';
    </script>   
<?php }elseif($topic=="HARDWARE"){?>

    <script>
        window.location = 'hardware.php';
    </script>   
<?php }elseif($topic=="IOS"){?>

    <script>
        window.location = 'ios.php';
    </script>   
<?php }else {?>

    <script>
        window.location = 'msoffice.php';
    </script>   
<?php  } ?>

Note:-

1.remove the very last }.

2.Try to do proper Indenting of code.

3.Try to use some code-editor which will let you know automatically about these type of errors while coding itself.

score 1 · Accepted Answer · answered Jan 02 '17 at 12:25

1

<?php
switch ($topic) {
    case "WINDOWS":
        $url = 'home.php';
        break;
    case "MAC":
        $url = 'mac.php';
        break;
    //more cases ......
    default:
        $url = 'msoffice.php';
        break;
}
?>
 <script>
   window.location = '<?php print $url; ?>';
 </script>

answered Jan 02 '17 at 12:25

Eugen

1,356
12
15

+10 because your answer is good too. – Alive to die - Anant Jan 03 '17 at 04:08

Parse error: syntax error, unexpected '{', expecting '(' in C:\xampp\htdocs\vft_forum\admin\admin_forum\poster.php on line 189

3 Answers3