Javascript function in php doesn't work

Question

I have a php function which ends with a refresh of the page and then throws a javascript function declared:

<script>
    var u = null;
    function tab(u) {
        $('#element1').css('display', 'block');
        $('#element2').css('display', 'none');
    }
</script>
<?php
    if (isset($_POST['submit1'])) {
        $tab = 1;
        header("Refresh:0");            
        echo "<script>window.scrollTo(0, 1000);</script>";
        echo "<script>tab(".$tab.");</script>";
    }
?>

The function of window.scrollto works, but the tab function not. I wrote ob_start and ob_end_flush to avoid headers problems.

there might be a problem because you are using `header` function after generating an output... — ewcz, Jan 07 '17 at 18:46
See here: http://stackoverflow.com/questions/1045845/how-to-call-a-javascript-function-from-php — Liam's musings, Jan 07 '17 at 18:49
What happens if you set the PHP $tab variable explicitly to a string: `$tab = "1";` (That is, to a PHP string. It will still be an integer to JavaScript.) Also, can you paste in the JavaScript that gets generated? — Tim Grant, Jan 07 '17 at 18:55

Ionut Necula · Answer 1 · 2017-01-07T19:14:37.083

2

You are missing a closing ) on the if statement. Try this:

  <script>
    var u = null;
    function tab(u) {
        $('#element1').css('display', 'block');
        $('#element2').css('display', 'none');
    }
</script>
<?php
    if (isset($_POST['submit1'])) {
        $tab = 1;
        header("Refresh:0");            
        echo "<script>window.scrollTo(0, 1000);</script>";
        echo "<script>tab(".$tab.");</script>";
    }
?>

The header("Refresh:0"); shoudn't be a problem as you said. In the worst case you will get an warning saying Warning: Cannot modify header information - headers already sent by....

Also, in development you should always have error_reporting turned on to be able to see the possible errors or warnings. You can turn on error reporting like this:

error_reporting(E_ALL);
ini_set('display_errors', 1);

Don't forget to remove/comment that on production/live.

edited Jan 07 '17 at 19:14

answered Jan 07 '17 at 18:51

Ionut Necula

11,107
4
45
69

Good catch!. Should it not throw error on server side? – Sandeep Nayak Jan 07 '17 at 18:54
I have it like this but writing the question I made a mistake. – gerardet46 Jan 07 '17 at 18:54
1

@SandeepNayak, it should have if he had the error reporting turned on. – Ionut Necula Jan 07 '17 at 18:55
@GerryStudios, let me check it again. – Ionut Necula Jan 07 '17 at 18:55
1

I've erased the header("Refresh:0") because I saw I don't need it and now it works, thanks. – gerardet46 Jan 07 '17 at 18:56

Javascript function in php doesn't work

1 Answers1