ExecutorService: awaitTermination VS while loop

Question

I have to wait for completion of all the threads in an executorService. Should I use

while(!executor.isTerminated()){...} or 
executor.awaitTermination(...)?

What are the pros and cons of these ways?

Answer 1

With executor.isTerminated() your current thread will keep running. with executor.awaitTermination() the current thread will be blocked. So it depends on what you want to do in your current thread. Do you want to do some tasks and periodically check for whether the executor is done, then use executor.isTerminated()? Or Is the current thread just waiting for the executor to finish. If yes, executor.awaitTermination() makes much more sense.

Do note that an Executor will only be terminated if the shutdown() or shutdownNow() is called.

Answer 2

Recommended way from oracle documentation link:

void shutdownAndAwaitTermination(ExecutorService pool) {
   pool.shutdown(); // Disable new tasks from being submitted
   try {
     // Wait a while for existing tasks to terminate
     if (!pool.awaitTermination(60, TimeUnit.SECONDS)) {
       pool.shutdownNow(); // Cancel currently executing tasks
       // Wait a while for tasks to respond to being cancelled
       if (!pool.awaitTermination(60, TimeUnit.SECONDS))
           System.err.println("Pool did not terminate");
     }
   } catch (InterruptedException ie) {
     // (Re-)Cancel if current thread also interrupted
     pool.shutdownNow();
     // Preserve interrupt status
     Thread.currentThread().interrupt();
   }
 }

if your threads are not completing with-in 120 seconds, you can change second if condition as :

while(!pool.awaitTermination(60, TimeUnit.SECONDS)) {
     Thread.sleep(60000);
}  

You can find other alternatives at @ wait until all threads finish their work in java

One more key note on usage of isTerminated:

boolean isTerminated()

Returns true if all tasks have completed following shut down. Note that isTerminated is never true unless either shutdown or shutdownNow was called first.