Style PHP variable in JavaScript

Question

<?php    
...
$name = trim($_POST["username"]);
...
echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style='color:red;'>'.$name.'</span> <br>login now";</script>';

?>

Why the style isn't working? When I erase the style and span the code is working fine.

"isn't working" meaning it prints(echo) nothing, so my guess is that this code is not valid... — Comrade57, Jan 09 '17 at 21:26
See: [How do I get PHP errors to display?](http://stackoverflow.com/questions/1053424/how-do-i-get-php-errors-to-display) — HPierce, Jan 09 '17 at 21:27

score 2 · Answer 1 · answered Jan 09 '17 at 21:24

2

Your need to escape the quotes around 'color:red;', that's invalid:

echo '<script type="text/javascript">document.getElementById("message").innerHTML=
"<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>'

answered Jan 09 '17 at 21:24

Jacob G

13,762
3
47
67

Thank you so much! – Comrade57 Jan 09 '17 at 21:29
No problem, glad I could help :) – Jacob G Jan 09 '17 at 21:37

Mohammad · Answer 2 · 2017-01-09T21:29:17.523

0

Your need to escape style=\'color:red;\'

<?php
echo '<div id="message"></div>
            <script type="text/javascript">document.getElementById("message").innerHTML=
                    "<span style=\'color:red;\'>'.$name.'</span> <br>login now";</script>';
?>

edited Jan 09 '17 at 21:29

answered Jan 09 '17 at 21:27

Mohammad

497
3
15

How's this any different than my answer? – Jacob G Jan 09 '17 at 21:28
oh , You sent this answer . – Mohammad Jan 09 '17 at 21:31
yeah, I guess we both had the same idea :) – Jacob G Jan 09 '17 at 21:32

Style PHP variable in JavaScript

2 Answers2