C++ Putting the smallest (out of 2 arrays) array number in a 3rd array[i]

Question

I've been trying to do a little program which allows the user to enter 5 numbers each (out of 2 arrays). Once that is done, there should be a function that compares the [i] number of both arrays and puts the bigger one in the 3rd array.

e.g array1[0] = 2; array2[0] = 5

That will result in array3[0] = 2.

Tried using the functions to achieve it, but for some reason, the result of all array3[i] numbers is equal to 5.

Here's my code:

#include <iostream>

using namespace std;

int array1[5], array2[5], array3[5];

void insert(int[], int);
float initialization(int[], int[], int[], int);


int main()
{
    const int size = 5;

    insert(array1, 5);
    cout << endl;
    insert(array2, 5);

    for (int i = 0; i < size; i++)
    {
        cout << "The " << i + 1 << ". number of the 3rd array is: " << initialization(array1, array2, array3, size) << endl;
    }

    system("PAUSE");
    return 0;
}

void insert(int array[], int size)
{
    for (int i = 0; i < size; i++)
    {
        cout << "Enter the " << i + 1 << ". number of the array: ";
        cin >> array[i];
    }
    cout << "\n";
}

float initialization(int array1[], int array2[], int array3[], int size)
{
    int r;
    for (int i = 0; i < size; i++)
    {
        r = i;
        if (array1[i] < array2[i])
        {
            array3[i] = array1[i];
        }
        else
        {
            array3[i] = array2[i];
        }

    }

    return array3[r];
}

Any help?

You'll need to learn how to use a debugger, and you'll learn a lot in the process. We won't do it for you, sorry. — Rakete1111, Jan 10 '17 at 18:24
`return array3[r];` -- What are you trying to return here? If you read your assignment carefully, where did it say you must return a value from the function? — PaulMcKenzie, Jan 10 '17 at 18:28
It appears that what the initialization functon returned was the 5th element of the array while it shouldn't have been. — TheDoomDestroyer, Jan 10 '17 at 18:33
As an aside, `initialization()` could be simplified significantly with the ternary operator. `array3[i] = (array1[i] < array2[i]) ? array1[i] : array2[i];` People might find it harder to read that way, though. — Justin Time - Reinstate Monica, Jan 10 '17 at 18:56
Also, [`system("pause");` ties your code to Windows, and isn't the most efficient](http://stackoverflow.com/questions/1107705/systempause-why-is-it-wrong). — Justin Time - Reinstate Monica, Jan 10 '17 at 18:57
@JustinTime Yes it is important to pause as efficiently as possible. — philipxy, Jan 18 '18 at 23:33

score 3 · Accepted Answer · answered Jan 10 '17 at 18:26

3

In function initialization, the value of r is always 5 when you return array3[r].

This is not even a valid memory access (i.e., array3[5] is UB).

Get rid of this return statement, and in the main function simply do:

initialization(array1, array2, array3, size);
cout << "The " << i + 1 << ". number of the 3rd array is: " << array3[i] << endl;

answered Jan 10 '17 at 18:26

goodvibration

5,980
4
28
61

I managed to do a fix. Thank you for the help. Can't believe I didn't actually notice it. – TheDoomDestroyer Jan 10 '17 at 18:32

C++ Putting the smallest (out of 2 arrays) array number in a 3rd array[i]

1 Answers1