JS function works from console, but onclick returns blank page

Question

I'm working on some HTML5 app with JS, and I've encountered a problem. Function written in js is working when called from console, but when clicking on button with onclick it returns a blank page.

here's the function:

function open() {
document.getElementById("chatBox").innerHTML = localStorage.chat;
return false;
}

and here's button:

<button id="openConButton" onclick="open()">Open</button>

Oh, and important one: other function from this script file are working just fine. Any ideas?

It isn't inside a form, but others aren't inside form eighter, and they still works, with other functions of course — egzaell, Jan 12 '17 at 15:34
Common pitfall; your button is calling "document.open()". Just rename the function. — , Jan 12 '17 at 15:35
@MikeC This is more for curiousity sake, but would that matter if the click is tied to a JavaScript function and not a form submit? — War10ck, Jan 12 '17 at 15:38
you also shouldn't use the onclick html attribute and global scope functions. You should attach the click event handler with javascript and keep your code, variables, and functions in another scope (ie. functions and IIFEs) — Zorgatone, Jan 12 '17 at 15:38
@War10ck [Yup. It totally matters](http://stackoverflow.com/questions/932653/how-to-prevent-buttons-from-submitting-forms) ;) — Mike Cluck, Jan 12 '17 at 15:39
@MikeC Ah, ok, I misunderstood where you were going with that. Thanks for thel link! — War10ck, Jan 12 '17 at 15:40

score 3 · Accepted Answer · edited Jan 12 '17 at 15:38

3

Common pitfall; your button is calling document.open(). Just rename the function.

edited Jan 12 '17 at 15:38

War10ck

12,387
7
41
54

answered Jan 12 '17 at 15:37

JS function works from console, but onclick returns blank page

1 Answers1