How to generate random number and use it for action?

Question

My main idea is generating some kind of "random greetings" and the idea is to generate a random number, and depends on the number to display "random greeting". Here is my non working code:

<p class="status">Your random splash screen: <span id="greeting">You don't have one</span></p>
<script>
var x = Math.floor((Math.random() * 4) + 1);
if (x == 1) {
  document.getElementById("greeting").innerHTML = "Greeting 1";
} else if (x == 2) {
  document.getElementById("greeting").innerHTML = "Greeting 2";
} else if (x == 3) {
  document.getElementById("greeting").innerHTML = "Greeting 3";
} else if (x == 4) {
  document.getElementById("greeting").innerHTML = "Greeting 4";
}
</script>

I have no idea what's wrong in it, please help!

See [Getting random value from an array](http://stackoverflow.com/questions/4550505/getting-random-value-from-an-array) — Alex K., Jan 13 '17 at 16:41
Maybe some kind of race condition is happening? Try putting the script inside the — Emanuel Landeholm, Jan 13 '17 at 16:41
@EmanuelLandeholm There is no race condition happening. Putting the script in the would fail as the #greeting element wouldn't be loaded yet. — Mike Cluck, Jan 13 '17 at 16:43
nothing wrong with if else ladder but efficient way would be mapping numbers to greetings like in an array — Arun Sharma, Jan 13 '17 at 17:36
There's also no element with the id "greeting". There's a span with the id "greting", which you probably meant. — Lee Daniel Crocker, Jan 13 '17 at 19:08

score 0 · Accepted Answer · answered Jan 13 '17 at 16:41

0

As you can see here the code works fine:

var x = Math.floor(Math.random() * 4);
var greetings = ['Greeting 1', 'Greeting 2', 'Greeting 3', 'Greeting 4'];

document.getElementById("greeting").innerHTML = greetings[x];

<p id="greeting">Nice to meet you!</p>

answered Jan 13 '17 at 16:41

Dominic

62,658
20
139
163

Did you run the snippet? All we can do is help using the info provided, you'll have to be more detailed with where/how you're trying to use this! Log out `document.getElementById("greeting")` and what do you see? – Dominic Jan 13 '17 at 16:58
I am going to use this @ www.beon.ga while it is loading the website ;) – undefined Jan 13 '17 at 17:00
1

Just making some fixes – undefined Jan 13 '17 at 17:00

How to generate random number and use it for action?

1 Answers1