Fatal error of PHP

Question

I'm doing an admin panel and I'm doing a form for adding users. My code below:

        <form class="form-horizontal">
<fieldset>

<!-- Form Name -->
<legend>Add user</legend>

<!-- Prepended text-->
<div class="form-group">
  <label class="col-md-4 control-label" for="newuser">Username</label>
  <div class="col-md-4">
    <div class="input-group">
      <span class="input-group-addon">@</span>
      <input id="newuser" name="newuser" class="form-control" placeholder="Username" type="text" required="">
    </div>
    <p class="help-block">Put the new users username here</p>
  </div>
</div>

<!-- Password input-->
<div class="form-group">
  <label class="col-md-4 control-label" for="userpw">New user password</label>
  <div class="col-md-4">
    <input id="userpw" name="userpw" type="password" placeholder="Password" class="form-control input-md" required="">
    <span class="help-block">Enter new user's password here!</span>
  </div>
</div>

<!-- Select Basic -->
<div class="form-group">
  <label class="col-md-4 control-label" for="permissions">Choose permissions</label>
  <div class="col-md-4">
    <select id="permissions" name="permissions" class="form-control">
      <option value="1">System administrator</option>
      <option value="2">Editor</option>
      <option value="3">Developer</option>
      <option value="4">Normal user</option>
    </select>
  </div>
</div>

<!-- Button -->
<div class="form-group">
  <label class="col-md-4 control-label" for="btn_send">Send request to server</label>
  <div class="col-md-4">
    <button id="btn_send" name="btn_send" class="btn btn-primary">Send it!</button>
  </div>
</div>

</fieldset>
</form>
<?php
$newuser = $_GET['newuser']; 
$userpw = $_GET['userpw'];
$permission = $_GET['permissions'];


if(isset($newuser and $userpw and $permission) {
    $sql = "INSERT INTO users(username,userpw,permission)VALUES('$newuser', '$userpw','$permission')";

    mysql_query($sql);
}
else {
echo "error";}

And I Get:

Fatal error: Cannot use isset() on the result of an expression (you can use "null !== expression" instead) in C:\xampp\htdocs\lumino\usermanagement.php on line 95

I couldn't fix it anyhow, playing with this for like 5 hours. It's doing $_GET method, so I get the url like:

mysite.com/usermanagement.php?newuser=Berkay&userpw=18042003&permissions=3&btn_send=

`if(isset($newuser and $userpw and $permission)` guess what's missing? — Funk Forty Niner, Feb 03 '17 at 15:25
@JustOnUnderMillions *Prolly*. But I didn't go any further in the code; call me lazy ;-) — Funk Forty Niner, Feb 03 '17 at 16:02

score 1 · Accepted Answer · edited Feb 13 '17 at 14:27

1

Using isset, you can't have multiple items inside it:

if(isset($newuser and $userpw and $permission) {

Needs to become:

if(isset($newuser) && isset($userpw) && isset($permission)) {

Or:

if(isset($newuser, $userpw, $permission)) {

edited Feb 13 '17 at 14:27

Funk Forty Niner

74,450
15
68
141

answered Feb 03 '17 at 15:24

Farkie

3,307
2
22
33

Actually, you can have multiple values in an isset. `isset($a, $b, c)` http://php.net/manual/en/function.isset.php – M. Eriksson Feb 03 '17 at 15:27
Thanks. Now how can I upload this to mysql table? – Berkay Gündüz Feb 03 '17 at 15:27
@BerkayGündüz - That's another issue. Mark the answer you think is best here and create another question where you explain the issues you're having with your database query. – M. Eriksson Feb 03 '17 at 15:30

Clorichel · Answer 2 · 2017-02-03T15:27:44.077

1

You just miss a ) and a set of ,:

if(isset($newuser, $userpw, $permission)) {
    $sql = "INSERT INTO users(username,userpw,permission)VALUES('$newuser', '$userpw','$permission')";

    mysql_query($sql);
}

edited Feb 03 '17 at 15:27

answered Feb 03 '17 at 15:25

Clorichel

1,940
1
13
24

Did you read the error message? – JustOnUnderMillions Feb 03 '17 at 15:26
He does have a valid point, though – Farkie Feb 03 '17 at 15:27
Saw the missing `)` first (jumped to my eyes!). Just edited my answer. – Clorichel Feb 03 '17 at 15:28

Fatal error of PHP

2 Answers2