unable to update the record in mysqli

Question

I am just trying to access following code but unfortunately, I couldn't run this script successfully. always got an error not updated. in my db i have only 3 field id, lname, fname here is following my code.

index.php

<div class="left-box">
            <h3>UPDATE</h3>
            <form action="update.php" method="post">
            <select name="choice">
                    <option value = "action">Update First or Last Name</option>
                    <option value = "fname">First Name</option>
                    <option value = "lname">Last Name</option>
            </select>
                <input type="text" name="id" placeholder="Choose ID"><br>
                <input type="text" name="new_value" placeholder="New Value"><br>
                <button type="submit" name="submit" value="send">UPDATE</button>
            </form>
        </div>

update.php

<?php
if(isset($_POST["submit"])){
    $choice = $_POST["choice"];
    $id = $_POST["id"];
    $new_value = $_POST["new_value"];
    if($id != "" AND $new_value != "" AND $choice != "")
    {
        require('db.php');
        $db_connection = connect_db();

        $status = update_data($db_connection,$id,$choice,$new_value);
        if($status) {
            header("Location: index.php?id=success&v=Updated succesfully");
        }
        header("Location: index.php?id=error&v=Not Updated");
    }
    else {
        //echo '<script type="text/javascript">alert("hi")</script>';
        header("Location: index.php?id=error&v=Error: All Fields Required");
    }
}
else {
    header("Location:index.php");
} ?>

db.php

   function connect_db() {
$con = mysqli_connect("localhost","root","","test");
if(!$con){
    die("database connection not established");
}
return $con; }

function update_data($con,$id,$choice,$new_value){  
$sql="";

if($choice == "fname") {
            $sql = "UPDATE crud SET fname = '$new_value' WHERE id = '$id' ";
        }
        else{
            $sql = "UPDATE crud SET lname = '$new_value' WHERE id = '$id' ";
        }
        $result = mysqli_query($con, $sql);

        if(mysqli_affected_rows($con))
        {
            return true;
        }
        return false;
}

Are fields in your database updated after you run this script? — u_mulder, Feb 08 '17 at 07:08
No, when i check query in sql window then ran successfully but not in gui — nady gold, Feb 08 '17 at 07:12
did you debug your php code with echo and found that by which line you are getting error? — Mohit Saxena, Feb 08 '17 at 07:13
You don't need quotes around $id ! And take care your code is vulnerable to sql injections. Use mysqli_real_escape_string on your $_POST vars to prevent them ! — Quentin Le Bévillon, Feb 08 '17 at 07:14
when i ran $sql directly on phpmyadmin then it run successfully but here it's not worked. i have also run with or without quotes $id — nady gold, Feb 08 '17 at 07:16
Later i'll protect with sql injection but here is main problem it doesn't run successfully. — nady gold, Feb 08 '17 at 07:18

score 0 · Accepted Answer · answered Feb 08 '17 at 07:17

0

Try below query.

$sql = "UPDATE crud SET fname = '".$new_value."' WHERE id = $id";
$sql = "UPDATE crud SET lname = '".$new_value."' WHERE id = $id";

answered Feb 08 '17 at 07:17

Harsh Barach

947
9
18

Thanks Harsh... It works :) – nady gold Feb 08 '17 at 07:22
@nadygold welcome. – Harsh Barach Feb 08 '17 at 07:24
this answer is a fraud as it doesn't make any difference. – Your Common Sense Feb 08 '17 at 07:52
@YourCommonSense please stop commenting bed things as any user get its proper answer from my reply. – Harsh Barach Feb 08 '17 at 09:28

unable to update the record in mysqli

1 Answers1