how solve this appears illegal character when i click two times?

Question

I have this function works well when i click the first time but when i click the second time receive a error in this part

eval("var " + data + "=sinvnword;");

Code:

$('a.play-video').click(function(){
  var currentLocation = window.location;


  var fullurl = window.location.href; 
  url =  fullurl.split("sendx")[1];

  var sinvnword = $('.question-label.active').last().text();

  console.log(sinvnword);
  var data =url ;
  eval("var " + data + "=sinvnword;");

  console.log(AXY + "GETIT");
  console.log(AXY+"mor");

  console.log(AXY + "muerte"); 
});

Whatever you are trying to do, don't use `eval`. You have a pretty nasty XSS vulnerability there. — Alexander O'Mara, Feb 13 '17 at 23:49
I don't really know what you are trying to do, but this may help: https://stackoverflow.com/questions/5117127/use-dynamic-variable-names-in-javascript — Alexander O'Mara, Feb 13 '17 at 23:50
i see my error in the url appears a "#" because i click one time — zerozero1024, Feb 13 '17 at 23:54
Still, *don't use eval*. The way you are using it compromises your site's security. — Alexander O'Mara, Feb 13 '17 at 23:55
What error do you get? Is it declaring the same thing twice with `var`? — Jacob, Feb 14 '17 at 00:08
the error was a # of the url that appears after the first click — zerozero1024, Feb 14 '17 at 00:21

score 0 · Accepted Answer · answered Feb 14 '17 at 00:11

Rather than using eval to create dynamic variable names, simply use dynamic property names:

var data = {};

$('a.play-video').click(function(){
  var currentLocation = window.location;

  var fullurl = window.location.href; 
  var key = fullurl.split("sendx")[1];

  var sinvnword = $('.question-label.active').last().text();

  console.log(sinvnword);
  data[key] = sinvnword;

  console.log(AXY + "GETIT");
  console.log(AXY+"mor");

  console.log(AXY + "muerte"); 
});

how solve this appears illegal character when i click two times?

1 Answers1