Javascript onclick attachment indexer issue

Question

I have problem with the following 'registerHandlers' javascript function. When I am trying to attach the onclick even, it always displaying '3'. Here how it should work;

An alert should display anchor's zero-based index within a document instead of following the link.

For example, in the document below, the alert should display "2" when Google anchor is clicked since it is the third anchor element in the document and its zero-based index is 2.

Here the script and test page in JSFiddle

function registerHandlers() {
  var as = document.getElementsByTagName('a');
  for (var i = 0; i < as.length; i++) {
    as[i].onclick = function() {
      alert(i);
      return false;
    }
  }
}

It should always display 3 because when you click the loop index is already updated. — Aslam, Feb 15 '17 at 11:46

score 1 · Accepted Answer · answered Feb 15 '17 at 11:57

1

This should work :)

function registerHandlers() {
  var as = document.getElementsByTagName('a');
  var j = 1;
  for (var i = 0; i < as.length; i++) {
    as[i].onclick = function() {
      alert(j);
      j++;
    }
  }
}

answered Feb 15 '17 at 11:57

Aslam

9,204
4
35
51

1

This does. Thanks hunzaboy! Although for zero base, j should initialise with 0. – Haseeb Sd Feb 15 '17 at 12:17
Well you can use whatever the base you want :) – Aslam Feb 16 '17 at 07:35

Javascript onclick attachment indexer issue

1 Answers1