Please how do I sort map elements based on values in ascending order in java?

Question

I am trying to sort map elements (based on values) by using Collections.sort(). The problem is that my program sorts the elements in descending order instead of sorting it in ascending order. How can I sort it in ascending order? Below is my code.

package hashTableRR;

import java.util.*;
import java.util.Map.Entry;
public class OrderByValue {

    public static void main(String [] args){

    Map<Integer, Integer> map = new HashMap<Integer, Integer>();
    map.put(1, 4);
    map.put(2, 6);
    map.put(3, 1);
    map.put(4, 1);
    map.put(6, 8);
    map.put(7, 5);

    Set<Entry<Integer, Integer>> set = map.entrySet();
    List<Entry<Integer, Integer>> list = new ArrayList<Entry<Integer, Integer>>(set);
    Collections.sort(list, new Comparator<Map.Entry<Integer, Integer>>()
    {
        public int compare(Map.Entry<Integer, Integer> o1, Map.Entry<Integer, Integer> o2){
            return(o2.getValue()).compareTo(o1.getValue());
        }
    }

            );

    System.out.println("Keys\t\tValues");
    for(Map.Entry<Integer, Integer> entry:list)
    {
        System.out.println(" "+entry.getKey()+"\t\t  "+entry.getValue());

    }       


    }
}

Try using `return(o1.getValue()).compareTo(o2.getValue());`. Please note that compare order matters. — aUserHimself, Feb 15 '17 at 14:45
Possible duplicate of [Sort a Map by values (Java)](http://stackoverflow.com/questions/109383/sort-a-mapkey-value-by-values-java) — Viktor Mellgren, Feb 15 '17 at 15:29

score 3 · Answer 1 · answered Feb 15 '17 at 14:47

3

Just change the order of variables in your compare function

return(o1.getValue()).compareTo(o2.getValue());

answered Feb 15 '17 at 14:47

Adam Kučera

424
5
15

Mena · Answer 2 · 2017-02-15T14:54:31.593

The problem is likely in your Comparator#compare implementation.

You are returning: o2.getValue().compareTo(o1.getValue())

For an ascending order, you should return: o1.getValue().compareTo(o2.getValue())

This will generate a negative value if o1 < o2, 0 if they're equal and a positive value if o2 > o1.

See slightly cryptical documentation here.

Here's an insight of what values you can expect your Comparator to return when performing a comparison of Integers in Java (full doc here):

the value 0 if this Integer is equal to the argument Integer; a value less than 0 if this Integer is numerically less than the argument Integer; and a value greater than 0 if this Integer is numerically greater than the argument Integer (signed comparison).

Thanks you so much for your help, all of you. – Miji05 Feb 15 '17 at 14:50 — Miji05, Feb 15 '17 at 14:50

score 1 · Answer 3 · answered Feb 15 '17 at 14:46

1

Just use :

return(o1.getValue()).compareTo(o2.getValue());

It will obviously inverse order

answered Feb 15 '17 at 14:46

Dmytro Grynets

923
11
29

Vazgen Torosyan · Answer 4 · 2017-02-15T15:25:16.447

 Map<Integer, Integer> unsortedMap = new HashMap<>();
    Map<Integer, Integer> sortedMap = new LinkedHashMap<>();
    unsortedMap.put(1, 4);
    unsortedMap.put(2, 6);
    unsortedMap.put(3, 1);
    unsortedMap.put(4, 1);
    unsortedMap.put(6, 8);
    unsortedMap.put(7, 5);


    unsortedMap.entrySet().
            stream().
            sorted(Map.Entry.<Integer, Integer>comparingByValue().reversed()).
            forEachOrdered(x -> sortedMap.put(x.getKey(), x.getValue()));

    System.out.println(sortedMap);

Use LinkedHashMap if you want to store your data in the order in which keys are inserted into the Map. HashMap doesn't guarantee any order.

Please how do I sort map elements based on values in ascending order in java?

4 Answers4