PHP mySQL success/failure redirect page

Question

So I've searched all over and found all sorts of solutions that just don't work.

I have a registration page that inserts data into my database, which works. I have an if/else statement that should redirect to one of two pages depending if the insertion was successful or not. Right now it just shows a blank page after the form is submitted.

<?php

$hostname="xxxxxxxxxxxxxxxxxxxxx";
$username="xxxxxxxxxxxx";
$password="xxxxxxxxx";
$database="xxxxxxxxxxxxx";



$db = new mysqli($hostname, $username, $password, $database); 
if ($db->connect_error){
    die("Connection failed: " . $db->connect_error);
    }

$pw = $_POST['pw'];
$UIN = $_POST['UIN'];

$sql = "INSERT INTO studentLogin (pw, UIN) VALUES ('$pw', '$UIN')";

if ($db->query($sql) === TRUE) {
    header('Location: http://my_url/success.php.php?msg=WELCOME STUDENT');
    exit();
}  else {
    header('Location: http://my_url/failure.php.php?msg=You must be a student to register for the student discussion page');
    exit();
}

$db->close();

?>

Are you sure you're redirecting to a valid URL? Also, you're seriously at risk of SQL injection. Use prepared statements to protect against it. — miken32, Feb 20 '17 at 23:30
please don't ignore comments or just leave or waiting for a magic answer. You've been asked to check for errors, what are they... `headers sent`? — Funk Forty Niner, Feb 20 '17 at 23:41
@Darren Maybe it's suppertime over their way, or their cat caught fire and had to run away. — Funk Forty Niner, Feb 20 '17 at 23:47
@Fred-ii- haha must be, orrrrrrrr they're trying to sell the cat! — Darren, Feb 20 '17 at 23:49
@Darren Do pawnshops take cats now? Must be a new trend then. — Funk Forty Niner, Feb 20 '17 at 23:49
Sorry currently in class, I added error reporting and it's telling me it can't modify the header because the output was already sent at line 27: (header('Location: http://my_url/failure.php.php?msg=You must be a student to register for the student discussion page');) I also removed the msg code and just have the url and it tells me the same thing. — Indyvette, Feb 20 '17 at 23:50
@Fred-ii- You're in the wrong profession, you should become a fortune teller! — Darren, Feb 20 '17 at 23:56
@Fred-ii- I'm currently reading the link you put up that was a previous post with what looks like the same issue I'm having. hopefully I'll have my answers there, thanks! the error reporting will definitely point me in the right direction — Indyvette, Feb 20 '17 at 23:56
@Darren yeah, maybe I'd get to actually "meet" more people hahaha!! — Funk Forty Niner, Feb 20 '17 at 23:56
@Indyvette welcome. You'll surely find your answers in that duplicate and do read it over very carefully and in its entirety. — Funk Forty Niner, Feb 20 '17 at 23:58

adrian · Answer 1 · 2017-07-16T04:44:39.920

-1

An URL cannot contain spaces. You should change the spaces into "%20", which is the percent-encoded equivalent of a space. There's more info on percent encoding on this page. You can also use the "+" symbol to symbolize the space character.

Also, consider enabling errors. If you do not, we will not be able to know what exactly is the issue (which there definitely is one, considering the fact that the page is not showing.)

edited Jul 16 '17 at 04:44

answered Feb 20 '17 at 23:30

adrian

1,439
1
15
23

what space in the URL? I don't see a space. – Funk Forty Niner Feb 20 '17 at 23:32
@Fred-ii- the ones in the get parameter `msg` perhaps? – Feb 20 '17 at 23:36
that's not a URL it's a message being echo'd in another page with the GET method `?msg`. This given if that file does have `$_GET`. What they have now is perfectly valid. – Funk Forty Niner Feb 20 '17 at 23:37
1

who upvoted this? – Funk Forty Niner Feb 20 '17 at 23:42
@nogad `?msg` isn't a file. You going to upvote the other answer too? – Funk Forty Niner Feb 20 '17 at 23:43
I upvoted fred.. and I guess you downvoted my answer.. you need to urlencode the message in the querystring in the header. – Michael Krikorev Feb 20 '17 at 23:44
i haven't voted, i was just making an observation (hides in the shed) – Feb 20 '17 at 23:45
@MichaelK I can honestly say that I did not downvote yours, just this one. So, don't make guesses you don't know unless it's a fact, which it isn't. – Funk Forty Niner Feb 20 '17 at 23:45
I'm sorry if I was unclear; what I was referencing was the "?msg" part on line 21 and line 24. – adrian Jul 16 '17 at 04:43

PHP mySQL success/failure redirect page

1 Answers1