how to send two variable from onclick to controller (codeigniter)

Question

i get something problem with send two variable to controller:

this my delete button :

<a href="javascript:void(0);" class="btn btn-danger" data-name="<?php echo $data->opsi_color?>" data-id="<?php echo $data->id_opsi_color?>" onclick="hapus_warna(this)"><i class="glyphicon glyphicon-remove"></i></a>

this javascript :

function hapus_warna(obj)
{
    var id = $(obj).attr('data-id');
    var name = $(obj).attr('data-name');

    if(confirm('Apa anda yakin ingin menghapus '+name+'?')) {
          // ajax delete data from database
          $.ajax({
            url : baseURL + "trueaccon2194/opsional/warna_dihapuskan/" +id +name,
            type: "GET",
            success: function(data) {
               location.reload();
            },
            error: function (jqXHR, textStatus, errorThrown) {
               alert('Error deleting data');
            }
        });
     }
}

i will send var id and var name to controller for I manage this my controller :

function warna_dihapuskan($id,$name){
    $target = $this->input->get('data-name');
    $this->opsional_adm->warna_telah_dihapus($id);
    log_helper("warna", "menghapus warna ".$name."");
}

score 1 · Answer 1 · answered Feb 21 '17 at 03:47

1

Instead of this

$.ajax({
        url : baseURL + "trueaccon2194/opsional/warna_dihapuskan/" +id +name,

You should send like this

$.ajax({
        url : baseURL + "trueaccon2194/opsional/warna_dihapuskan/?data-id=" +id +'&data-name='+name,

answered Feb 21 '17 at 03:47

Saravanan Sampathkumar

3,201
1
20
46

A PHP Error was encountered Severity: Notice Message: Undefined variable: id Filename: trueaccon2194/opsional.php Line Number: 55 Backtrace: File: D:\xampp\htdocs\starsc\application\controllers\trueaccon2194\opsional.php Line: 55 Function: _error_handler A PHP Error was encountered Severity: Notice Message: Undefined variable: name Filename: trueaccon2194/opsional.php Line Number: 56 Backtrace: File: D:\xampp\htdocs\starsc\application\controllers\trueaccon2194\opsional.php Line: 56 Function: _error_handler – Mochammad Danny setyawan Feb 21 '17 at 04:00
How are you passing $id and $name to warna_dihapuskan($id,$name)? – Saravanan Sampathkumar Feb 21 '17 at 04:10
I think by sending variable in javascript earlier (+id + name) – Mochammad Danny setyawan Feb 21 '17 at 04:16
warna_dihapuskan is controller function? – Saravanan Sampathkumar Feb 21 '17 at 04:18
Instead do warna_dihapuskan() { $id = $this->input->get('data-id'); $name = $this->input->get('data-name'); } – Saravanan Sampathkumar Feb 21 '17 at 04:18
You can't pass parameters like that. – Saravanan Sampathkumar Feb 21 '17 at 04:19
how with ID that I can from javascript? if not with a variable name – Mochammad Danny setyawan Feb 21 '17 at 04:20
I'm not sure what you are saying? Could you please be more clear? – Saravanan Sampathkumar Feb 21 '17 at 04:21

score 0 · Accepted Answer · answered Feb 21 '17 at 04:46

Try this

$.ajax({
        url : baseURL + "trueaccon2194/opsional/warna_dihapuskan/?id=" +id +"&name="+name,

Retrieve the parameters like this in your controller function

function warna_dihapuskan(){
    $name = $this->input->get('name');
 $id = $this->input->get('id');

}

score 0 · Answer 3 · edited Feb 21 '17 at 15:57

In your HTML write this

<a href="javascript:void(0);" class="btn btn-danger" data-name="<?php echo $data->opsi_color?>" data-id="<?php echo $data->id_opsi_color?>" onclick="hapus_warna(<?php echo $data->id_opsi_color?>,<?php echo $data->opsi_color?>)"><i class="glyphicon glyphicon-remove"></i></a>

and in the function this

function hapus_warna(id,name)
{


    if(confirm('Apa anda yakin ingin menghapus '+name+'?')) {
          // ajax delete data from database
          $.ajax({
            url : baseURL + "trueaccon2194/opsional/warna_dihapuskan/" +id+"/" +name,
            type: "GET",
            success: function(data) {
               location.reload();
            },
            error: function (jqXHR, textStatus, errorThrown) {
               alert('Error deleting data');
            }
        });
     }
}

score 0 · Answer 4 · edited May 23 '17 at 11:53

I really prefer to do

method: 'POST'

Because then I can just do this inside the $ajax() method:

data: {
amount: id,
name: name
}

I do believe in this case it would be more interesting to use POST GET vs. POST ajax requests: When and how to use either?

and in stead of doing an onclick via inline code it is better to separate it from the view:

$(".my_class").on('click', function(){
...
});

how to send two variable from onclick to controller (codeigniter)

4 Answers4