PHP Get JSON & Insert Into DB Via PDO

Question

My PHP Code:

<?php
$host = ""; $db_name = ""; $username = ""; $password = "";

try {
    $conn = new PDO("mysql:host=".$host.";dbname=".$db_name, $username, $password);
} catch (PDOException $e) {
    echo 'Connection failed: ' . $e->getMessage();
}

$json = file_get_contents('');
$obj = json_decode($json, TRUE);

$stmt = $conn->prepare("INSERT INTO item_details (item_id,value,circulation) VALUES (:item_id,:value,:circulation");

foreach($obj['items'] as $key => $index) {
    $item_id = $key;
    $value = $index['value'];
    $circulation = $index['circulation'];

    $stmt->bindparam(":item_id", $item_id);
    $stmt->bindparam(":value", $value);
    $stmt->bindparam(":circulation", $circulation); 
    $stmt->execute();
}
?>

Problem:

I've tested via echoing the data to the page within my loop and the data is being retrieved, however no information is being submitted to my database.

Questions:

How can I improve upon my script to add relevant debugging lines to find the cause?
Is it obvious why my script does not work? If so, could you please explain this however my above question will aid my learning curve with future development!

Shouldn't be `bindParam` instead of `bindparam` ? [Typo] . You can add the execute part inside a try/catch block. — Catalin Minovici, Feb 25 '17 at 05:29

NeoVance · Accepted Answer · 2017-02-25T05:36:59.180

Catalin Minovici is correct about bindParam however PDO errors are not always thrown exceptions that can be caught, so a try/catch is only helpful here if you are going to check the PDO errors, and throw your own exception.

You have missed a parenthesis in your query preparation.

// missing paren...........................................................................................here: v
$stmt = $conn->prepare("INSERT INTO item_details (item_id,value,circulation) VALUES (:item_id,:value,:circulation)");

See the documentation for reading PDO query errors after your execute() on php.net

Additionally it is better to combine all of the results into a single insert operation, rather than executing a new insert on each iteration of the loop.

score 0 · Answer 2 · answered Feb 25 '17 at 05:31

0

You forgot closing bracket in values: prepare("INSERT INTO item_details (item_id,value,circulation) VALUES (:item_id,:value,:circulation)");

answered Feb 25 '17 at 05:31

Devansh Jani

57
1
10

PHP Get JSON & Insert Into DB Via PDO

My PHP Code:

Problem:

Questions:

2 Answers2