Using OR operator in an if statement

Asked Feb 25 '17 at 15:36

Active Feb 25 '17 at 16:04

Viewed 34 times

In the initial string, passed as an argument to the rot 13 function, the values of the letters are shifted by 13 places. Thus 'A' ↔ 'N', 'B' ↔ 'O' and so on.

I am trying to decode it by iterating through the string and using if else conditional statements. However, it seems that the OR(||) operator is not working properly.

" " has the value 32, so it should stay unchanged, but the result for this charater returns 19,(so 13 was still subtracted from 32).

Where is my mistake?

function rot13(str) {
  var x = "";
  var y = String.fromCharCode(x);
  for (i = 0; i < str.length; i++) {
    if (str.charCodeAt(i) > 65 || str.charCodeAt(i) < 78) {
      x += str.charCodeAt(i) - 13 + ",";
    } else if (str.charCodeAt(i) > 78 || str.charCodeAt(i) < 91) {
      x += str.charCodeAt(i) + 13 + ",";

    } else {
      x += str.charCodeAt(i) + ",";
    }


  }

  return x;
  //returns '70,56,69,69,19,67,53,68,69,19,67,65,77,54,'
}


console.log(rot13("SERR PBQR PNZC"));

edited Feb 25 '17 at 16:04

asked Feb 25 '17 at 15:36

Igor Schekotihin

1

Using OR with those conditions means true for all cases, you need AND those conditions, my my – buræquete Feb 25 '17 at 15:37
2

`if(str.charCodeAt(i) > 65` **`&&`** `str.charCodeAt(i) < 78)` – T.J. Crowder Feb 25 '17 at 15:38
1

Looking at the code, what about char code 78 (`N`)? It's neither `< 78` nor `> 78`... Is `N` not shifted? – T.J. Crowder Feb 25 '17 at 15:38
That's where the `else` comes in, @T.J.Crowder – Wes Foster Feb 25 '17 at 15:39
@WesFoster: I'm just wondering why `N` shouldn't be shifted, when `M` and `O` are. – T.J. Crowder Feb 25 '17 at 15:40
1

@T.J. Crowder Thanks for pointing it out, it should be <78 if the first statement and >77 in the second statement. – Igor Schekotihin Feb 25 '17 at 15:50

Using OR operator in an if statement

0 Answers0