C# Refine class property which is a List

Question

I have a class property:-

public List<string> szTypeOfFileList{get;set;}

As the name suggest, the property stores user selection of types of Files of interest (.txt, .doc, .rtf, .pdf, etc).

I am trying to assess whether there is way I could refine this List as it is being populated by user entries OR, if I should wait for all entries and then call a separate method to refine the property.

What I mean by this is, let's say a particular user input is ".doc/.docx". Currently, this would be stored in the List as a single string item. However I want it to be stored as two items separately. This will keep the code in one place and wont effect future modules and such.

private List<string> _szTypeOfFileList = new List<string>();
public List<string> szTypeOfFileList
{
    get
    {
        return _szTypeOfFileList;
    }
    set
    {
       // Some kind of validation/refining method here ?? //
    }
}

EDIT:-

Because my FileTypeList is coming from a checkboxList, I had to use a different methodology than the answer I accepted (which pointed me in the right direction).

 foreach (object itemchecked in FileTypeList.CheckedItems)
         {
            string[] values = itemchecked.ToString().Split('/');
            foreach(var item in values)
               TransactionBO.Instance.szTypeOfFileList.Add(item);
         }

This part of my code is in the UI class before it is passed on to the Business class.

Yeah. Avoid using Hungarian notation, especially in C#. It doesn't even make sense in this context since `sz` means null-terminated strings. C# strings are not null-terminated. :) — Ilian, Feb 27 '17 at 22:31

score 1 · Accepted Answer · answered Feb 27 '17 at 22:30

1

If you know that it'll always be split with a "/" character, just use a split on the string. Including a simple bit of verification to prevent obvious duplicates, you might do something along the lines of:

string[] values = x.Split('/');
foreach (string val in values) {
    if (!_szTypeOfFileList.Contains(val.ToLower().Trim())) {
        _szTypeOfFileList.Add(val.ToLower().Trim());
    }
}

You can also use an array of characters in place of the '/' to split against, if you need to consider multiple characters in that spot.

answered Feb 27 '17 at 22:30

Rob Wilkins

1,650
2
16
20

what is x in this context ? – Philo Feb 27 '17 at 22:46
It's a placeholder for a string from the passed list (eg, from "foreach (string x in value)" within the set). – Rob Wilkins Feb 27 '17 at 23:00
thanks Rob. I had to use a different technique since my workflow is a bit different. Adding it to my code above, let me know what you think. – Philo Feb 27 '17 at 23:27

score 1 · Answer 2 · edited May 23 '17 at 10:29

I would consider changing the List to something more generic. Do they really need a List ...or maybe a collection? array? enumerable ? (have a read through this link )

second, in your Set method, you'll want to take their input, break it up and add it. Here comes the question: is a list the best way of doing it ?
What about duplicate data ? do you just add it again? do you need to search for it in order to figure out if you're going to add it ?

Think about dictionary or hashtable, or any of type of collection that will help you out with your data . I would have a read through : this question (oh my ... wrong link ... nobody complained though ... so much for providing links ... :)

score 0 · Answer 3 · answered Feb 27 '17 at 22:28

0

var extensions = userInput.Split('/').ToList();

answered Feb 27 '17 at 22:28

l33t

18,692
16
103
180

C# Refine class property which is a List

3 Answers3