Shell script to verify the version of make on linux

Question

I am trying to write this shell script to verify the version of make which is installed on the linux, but unable to get it working. It will be great if someone can point me what I am missing here.

OUTPUT="$(make --version | head -1)"
echo "${OUTPUT}" | grep -o '[0-9]*[\.][0-9]*'

OP="$(echo \"${OUTPUT}\" | grep -o '[0-9]*[\.][0-9]*')" 
echo "${OP}"

if [ $OP -ge 3.82 ]; then
  echo "make version is greater than or equal to 3.82"
else:
  echo "make version is not greater than or equal to 3.82"
  exit 1
fi

Off the bat, I see that "op" should be "$op" in the if statement. Also, what happens when you run it now? — Joseph Sible-Reinstate Monica, Feb 28 '17 at 03:17
This is the output after the change: 3.82 ./test.sh: line 4: =3.82: command not found ./test.sh: line 7: [: -ge: unary operator expected — , Feb 28 '17 at 03:21
You should have only made that change in the if statement, not in the statement where you set the variable. — Joseph Sible-Reinstate Monica, Feb 28 '17 at 03:22
My bad, now output is: ./test.sh: line 7: [: 3.82: integer expression expected — , Feb 28 '17 at 03:23
Bash doesn't like floats on it's own. Try `if [[ $(echo $OP '>=' 3.82 | bc -l) -eq 1 ]]` — Guest, Feb 28 '17 at 03:32
@Sweety: .... or use Zsh instead of bash, which does floating point, for instance `if (( OP >= 3.82 )); then; ....` — user1934428, Feb 28 '17 at 05:43

score 1 · Accepted Answer · answered Feb 28 '17 at 03:30

1

You can only use test (aka [) to compare strings and integers, not versions like that. Here's two questions that show you ways to compare versions:

answered Feb 28 '17 at 03:30

Joseph Sible-Reinstate Monica

45,431
5
48
98

score 0 · Answer 2 · answered Feb 28 '17 at 06:24

0

don't use the char ":" after the key-word else:

if [ $OP -ge 3.82 ]; then
  echo "make version is greater than or equal to 3.82"
else
  echo "make version is not greater than or equal to 3.82"
  exit 1
fi

answered Feb 28 '17 at 06:24

Grégory Roche

162
2
9

Shell script to verify the version of make on linux

2 Answers2