I am new in android development.
Right now I have public class for execute HTTP Request (REST web service)
The problem is that I don't know how to use AsyncTask so whenever the request process take a long time it makes the application not responding and freeze.
here is my code
public class RESTClient {
private ArrayList<NameValuePair> params;
private ArrayList <NameValuePair> headers;
private String url;
private int responseCode;
private String message;
private String response;
public String getResponse() {
return response;
}
public String getErrorMessage() {
return message;
}
public int getResponseCode() {
return responseCode;
}
public enum RequestMethod
{
GET,
POST,
PUT,
DELETE
}
public RESTClient(String url)
{
this.url = url;
params = new ArrayList<NameValuePair>();
headers = new ArrayList<NameValuePair>();
}
public void AddParam(String name, String value)
{
params.add(new BasicNameValuePair(name, value));
}
public void AddHeader(String name, String value)
{
headers.add(new BasicNameValuePair(name, value));
}
public void Execute(RequestMethod method) throws Exception
{
switch(method) {
case GET:
{
//add parameters
String combinedParams = "";
if(!params.isEmpty()){
combinedParams += "?";
for(NameValuePair p : params)
{
String paramString = URLEncoder.encode(p.getValue(), "UTF-8");
if(combinedParams.length() > 1)
{
combinedParams += "|" + paramString;
}
else
{
combinedParams += paramString;
}
}
}
HttpGet request = new HttpGet(url);
executeRequest(request, url);
break;
}
case POST:
{
HttpPost request = new HttpPost(url);
//add headers
for(NameValuePair h : headers)
{
request.addHeader(h.getName(), h.getValue());
}
if(!params.isEmpty()){
NameValuePair param = params.get(0);
String val = param.getValue();
StringEntity data = new StringEntity("{\"Value\": \"" + val + "\"}");
data.setContentType("application/json");
request.setEntity(data);
}
executeRequest(request, url);
break;
}
case PUT:
{
HttpPut request = new HttpPut(url);
//add headers
for(NameValuePair h : headers)
{
request.addHeader(h.getName(), h.getValue());
}
if(!params.isEmpty()){
NameValuePair param = params.get(0);
String val = param.getValue();
StringEntity data = new StringEntity("{\"Value\": \"" + val + "\"}");
data.setContentType("application/json");
request.setEntity(data);
}
executeRequest(request, url);
break;
}
case DELETE:
{
HttpDelete request = new HttpDelete(url);
//add parameters
String combinedParams = "";
if(!params.isEmpty()){
combinedParams += "?";
for(NameValuePair p : params)
{
String paramString = URLEncoder.encode(p.getValue(), "UTF-8");
if(combinedParams.length() > 1)
{
combinedParams += "|" + paramString;
}
else
{
combinedParams += paramString;
}
}
}
executeRequest(request, url);
break;
}
}
}
private void executeRequest(HttpUriRequest request, String url)
{
HttpClient client = new DefaultHttpClient();
HttpResponse httpResponse;
try {
StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
StrictMode.setThreadPolicy(policy);
httpResponse = client.execute(request);
responseCode = httpResponse.getStatusLine().getStatusCode();
message = httpResponse.getStatusLine().getReasonPhrase();
HttpEntity entity = httpResponse.getEntity();
if (entity != null) {
InputStream instream = entity.getContent();
response = convertStreamToString(instream);
// Closing the input stream will trigger connection release
instream.close();
}
} catch (ClientProtocolException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
} catch (IOException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
}
}
private static String convertStreamToString(InputStream is) {
BufferedReader reader = new BufferedReader(new InputStreamReader(is));
StringBuilder sb = new StringBuilder();
String line = null;
try {
while ((line = reader.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
} finally {
try {
is.close();
} catch (IOException e) {
e.printStackTrace();
}
}
return sb.toString();
}
}
Is there any way to include asyncTask process into my class ?
--EDITED-- after using mad sciendtist
public class RESTClient {
private ArrayList<NameValuePair> params;
private ArrayList <NameValuePair> headers;
private String url;
private int responseCode;
private String message;
ProgressDialog progressBar;
private String response;
private Context mContext;
public String getResponse() {
return response;
}
public String getErrorMessage() {
return message;
}
public int getResponseCode() {
return responseCode;
}
public enum RequestMethod
{
GET,
POST,
PUT,
DELETE
}
public RESTClient(String url)
{
this.url = url;
params = new ArrayList<NameValuePair>();
headers = new ArrayList<NameValuePair>();
}
public void AddParam(String name, String value)
{
params.add(new BasicNameValuePair(name, value));
}
public void AddHeader(String name, String value)
{
headers.add(new BasicNameValuePair(name, value));
}
public String Execute(RequestMethod method) throws Exception
{
switch(method) {
case GET:
{
//add parameters
String combinedParams = "";
if(!params.isEmpty()){
combinedParams += "?";
for(NameValuePair p : params)
{
String paramString = URLEncoder.encode(p.getValue(), "UTF-8");
if(combinedParams.length() > 1)
{
combinedParams += "|" + paramString;
}
else
{
combinedParams += paramString;
}
}
}
HttpGet request = new HttpGet(url);
// IM CALLING THE ASYNCTASK HERE
return new HttpRequest(request, url).get();
break;
}
default:
return "";
break;
}
}
private void executeRequest(HttpUriRequest request, String url)
{
HttpClient client = new DefaultHttpClient();
HttpResponse httpResponse;
try {
StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
StrictMode.setThreadPolicy(policy);
httpResponse = client.execute(request);
responseCode = httpResponse.getStatusLine().getStatusCode();
message = httpResponse.getStatusLine().getReasonPhrase();
HttpEntity entity = httpResponse.getEntity();
if (entity != null) {
InputStream instream = entity.getContent();
response = convertStreamToString(instream);
// Closing the input stream will trigger connection release
instream.close();
}
} catch (ClientProtocolException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
} catch (IOException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
}
}
private static String convertStreamToString(InputStream is) {
BufferedReader reader = new BufferedReader(new InputStreamReader(is));
StringBuilder sb = new StringBuilder();
String line = null;
try {
while ((line = reader.readLine()) != null) {
sb.append(line);
}
} catch (IOException e) {
e.printStackTrace();
} finally {
try {
is.close();
} catch (IOException e) {
e.printStackTrace();
}
}
return sb.toString();
}
private class HttpRequest extends AsyncTask<HttpUriRequest,Void, String> {
private HttpUriRequest httpUriRequest;
private String url;
public HttpRequest(HttpUriRequest httpUriRequest , String url) {
this.httpUriRequest = httpUriRequest;
this.url = url;
}
@Override
protected String doInBackground(HttpUriRequest... params) {
// perform all network task on a different thread (i.e not on the main thread)
HttpClient client = new DefaultHttpClient();
String response=null;
HttpResponse httpResponse;
try {
StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder().permitAll().build();
StrictMode.setThreadPolicy(policy);
httpResponse = client.execute(httpUriRequest);
responseCode = httpResponse.getStatusLine().getStatusCode();
message = httpResponse.getStatusLine().getReasonPhrase();
HttpEntity entity = httpResponse.getEntity();
if (entity != null) {
InputStream instream = entity.getContent();
response = convertStreamToString(instream);
// Closing the input stream will trigger connection release
instream.close();
}
} catch (ClientProtocolException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
} catch (IOException e) {
client.getConnectionManager().shutdown();
e.printStackTrace();
}
// return the response;
return response;
}
@Override
protected void onPreExecute() {
super.onPreExecute();
// do not forget to add a progress dialog here or a progressbar
}
@Override
protected void onPostExecute(String s) {
super.onPostExecute(s);
if (!TextUtils.isEmpty(s)){
// on succesfull callback. hide the progres bar or dialog
}
}
}
}
and this is my activity when calling async restclient, and i need to get the response json back
Login.Java
public class Login extends AppCompatActivity {
private static String URLService;
// UI references.
private EditText USERID;
private EditText PASSWORD;
private View mProgressView;
private View mLoginFormView;
public static String UserID;
private static String Version="3.0";
private String VersionID;
private String VersionStatus;
private String hashed="";
private String Enc_Pass="";
private int responseCode;
Context context;
ProgressDialog mProgressDialog;
private String message;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_login);
// Set up the login form.
USERID = (EditText)findViewById(R.id.userID);
//populateAutoComplete();
URLService = getString(R.string.URLService);
Enc_Pass = getString(R.string.password_encryption);
PASSWORD = (EditText) findViewById(R.id.password);
Button LOGINBUTTON = (Button) findViewById(R.id.email_sign_in_button);
LOGINBUTTON.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View view) {
attemptLogin();
}
});
mProgressView = findViewById(R.id.login_progress);
SharedPreferences pref = getApplicationContext().getSharedPreferences("MyPref", MODE_PRIVATE);
UserID = pref.getString("userId", "");
if (!UserID.toString().equals(""))
{
Intent i = new Intent(Login.this, Index.class);
startActivity(i);
}
else
{
}
}
private void attemptLogin() {
// Reset errors.
USERID.setError(null);
PASSWORD.setError(null);
// Store values at the time of the login attempt.
try {
String valueEncrypt = strUserId + "|" + strPassword;
String encc = "";
try {
encc = AndroidCrypt.encrypt(Enc_Pass,valueEncrypt);
encc = encc.replace("+", "%2B");
}catch (GeneralSecurityException e){
//handle error
}
// new BigProccess(Login.this, ProgressDialog.STYLE_SPINNER).execute();
// new HttpRequestMet(URLService+"do?method=dologin&value=" +encc,"GET").execute();
RESTClient client = new RESTClient(URLService+"do?method=dologin&value=" +encc);
client.Execute(RESTClient.RequestMethod.GET);
String response = client.getResponse();
response = response.replace("\\\"", "\"");
response = response.substring(1, response.length() - 1);
JSONParser jsonParser = new JSONParser();
JSONObject jsonObject = (JSONObject) jsonParser.parse(response);
Status = jsonObject.get("Status").toString();
if (Status == "true") {
String dataku = jsonObject.get("Data").toString();
try {
dataku = AndroidCrypt.decrypt(Enc_Pass, dataku);
}catch (GeneralSecurityException e){
//handle error - could be due to incorrect password or tampered encryptedMsg
}
JSONParser parser = new JSONParser();
JSONObject structure = (JSONObject) parser.parse(dataku);
Toast.makeText(getApplicationContext(), "Welcome Back Mr./Mrs. " + FullName,
Toast.LENGTH_SHORT).show();
Intent i = new Intent(Login.this, Index.class);
startActivity(i);
// finish();
} else {
Toast.makeText(getApplicationContext(), "Login Failed",
Toast.LENGTH_SHORT).show();
}
} catch (Exception e) {
e.printStackTrace();
Toast.makeText(getApplicationContext(),"Cant Connect to server, please try again later",
Toast.LENGTH_SHORT).show();
}
}
}
}
