non-static variable deck cannot be referenced from a static context

Question

I´m getting error non-static variable deck cannot be referenced from a static context from this piece of code. I would like to understand what wrong is going there. I´m new to java.

public class CardDeck extends java.lang.Object 
{
    private  int size;
    private Stack<Card> deck;
    public CardDeck(int size)
    {
        this.deck = new Stack<Card>();
        this.size = size;
    }
    public static CardDeck createStandardDeck()
    {

            for (int i = 1; i <= 13; i++) { deck.push(new Card(Card.Color.CLUBS,i)); }
            for (int i = 1; i <= 13; i++) { deck.push(new Card(Card.Color.DIAMONDS,i)); }
            for (int i = 1; i <= 13; i++) { deck.push(new Card(Card.Color.HEARTS,i)); }
            for (int i = 1; i <= 13; i++) { deck.push(new Card(Card.Color.SPADES,i)); }
        return deck;
    }

first thing no need to extend Object class .Every superclass by default extends Object class.can you post your push method? — santosh gore, Mar 03 '17 at 11:03

Anand Undavia · Accepted Answer · 2017-03-03T11:04:12.617

1

Change your mathod as follows :

public static CardDeck createStandardDeck() {
    CardDeck myDeck = new CardDeck(13*4);
    for (int i = 1; i <= 13; i++) { myDeck.deck.push(new Card(Card.Color.CLUBS,i)); }
    for (int i = 1; i <= 13; i++) { myDeck.deck.push(new Card(Card.Color.DIAMONDS,i)); }
    for (int i = 1; i <= 13; i++) { myDeck.deck.push(new Card(Card.Color.HEARTS,i)); }
    for (int i = 1; i <= 13; i++) { myDeck.deck.push(new Card(Card.Color.SPADES,i)); }
    return myDeck;
}

edited Mar 03 '17 at 11:04

answered Mar 03 '17 at 10:54

Anand Undavia

3,493
5
19
33

You actually can omit `size` field altogether. You can always get the size by `deck.size()` in constant time. I don't see a point saving the `size` as a field – Anand Undavia Mar 03 '17 at 10:58
It throws error symbol: method push(Card) location: variable myDeck of type CardDeck /tmp/java_AZguK4/CardDeck.java:18: error: cannot find symbol – Tomáš Dubovský Mar 03 '17 at 11:00
Yeah I missed the reference to deck. Edited the answer. Should work now – Anand Undavia Mar 03 '17 at 11:04

non-static variable deck cannot be referenced from a static context

1 Answers1