Linear Search Array String

Question

I need to find a string element in my array but when I check to see, it always comes up as found, even if its not the case. I am trying to call a method.

    String name = "";
    boolean result = false;




   if (option == 5)
            {
        System.out.println("Please enter a students name");
        name = input.next();

        linearSearch(student);


        if (result = true)
        {System.out.println(name+" found in element ");}

        else
        {System.out.println(name+" not found in element ");}


    }


public static boolean linearSearch(String b[])
{
String key = null;
boolean searchReturn = false;
for(int i = 0; i < b.length; i++)
{
    //if key is found - return position of key i.e. n
    if( b[i] == key)
    searchReturn = true;
}

return searchReturn;

``if(result = true)`` should be ``if(result == true)`` or simply ``if(result)``. — f1sh, Mar 03 '17 at 12:15
And a third bug, you're not actually using the given `name`, instead you always compare with `key` which is `null`. — Jiri Tousek, Mar 03 '17 at 12:17
`if (result = true)`: pay attention to any warning messages output by the compiler. — Raedwald, Jul 23 '19 at 10:11

score 1 · Answer 1 · answered Mar 03 '17 at 12:43

1

String equality should be checked with String.equals(str) method.

Try

for(int i = 0; i < b.length; i++)
     {
        //if key is found - return position of key i.e. n
        if( b[i].equals(name))
        searchReturn = true;
    }

answered Mar 03 '17 at 12:43

Regie Baguio

241
5
13

when I do it this way, it is coming back as not being found, even if it is correct – Sean Mccarthy Mar 06 '17 at 17:30

score 0 · Answer 2 · answered Mar 03 '17 at 12:16

0

firstly you should call if(result == true){} //you performing a assignment.

answered Mar 03 '17 at 12:16

Remario

3,813
2
18
25

also where did the student variable came from? – Remario Mar 03 '17 at 12:17
Its the name of my string array, im calling my method into the if statement – Sean Mccarthy Mar 06 '17 at 17:28

Linear Search Array String

2 Answers2