Number to Words

Question

I'm not getting where my code is getting wrong even I Checked for many of the border cases

import java.util.*;
class fun
{
    String a[] = {"", "One", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Eleven", "Twelve", "Thirteen", "Fourteen", "Fifteen", "Sixteen", "Seventeen", "Eighteen", "Nineteen"};
    String b[] = {"", "Ten", "Twenty", "Thirty", "Forty", "Fifty", "Sixty", "Seventy", "Eighty", "Ninety"};
    String dis(int n)
    {
        String s ="";
        if(n/100>0)
            s+=a[n/100]+" Hundred ";
        if(n%100/10==0)
            s+=a[n%10];
        else if(n%100/10==1)
            s+=a[n%100];
        else
            s+=b[n%100/10]+" "+a[n%10];
        return s;
    }
}
public class Solution {
    public static void main(String[] args) {
        Scanner sc = new Scanner(System.in);
        int t = sc.nextInt(), a, b, c, d, e;
        fun f = new fun();
        while(t-->0)
        {
            String Str="";
            long n = sc.nextLong();
            a=(int)(n/Math.pow(10,12));
            b=(int)(n/Math.pow(10,9)%1000);
            c=(int)(n/Math.pow(10,6)%1000);
            d=(int)(n/Math.pow(10,3)%1000);
            e=(int)(n%1000);
            if(a==1)
                Str = "One Trillion";
            else
            {
                if(b!=0)
                    Str+=f.dis(b)+" Billion ";
                if(c!=0)
                    Str+=f.dis(c)+" Million ";
                if(d!=0)
                    Str+=f.dis(d)+" Thousand ";
                Str+=f.dis(e);
            }
            System.out.println(Str);
        }
    }
}

If input is:
1
104382426112

then output is:
One Hundred Four Billion Three Hundred Eighty Two Million Four Hundred Twenty Six Thousand One Hundred Twelve

what did you mean `1 104382426112` did you check with `1 space 104382426112` or what? — Youcef LAIDANI, Mar 03 '17 at 13:34
@UnknowableIneffible If no constructor is defined in a class java will add a default constructor. — OH GOD SPIDERS, Mar 03 '17 at 13:37
You can help people answer you by making your question easier to understand; i.e. what is your expected output and what is it outputting instead? — Klitos Kyriacou, Mar 03 '17 at 13:40
Does this help you? http://stackoverflow.com/questions/3911966/how-to-convert-number-to-words-in-java — gvlachakis, Mar 03 '17 at 13:48
Possible duplicate of [How to convert number to words in java](http://stackoverflow.com/questions/3911966/how-to-convert-number-to-words-in-java) — Markus Lausberg, Mar 03 '17 at 13:51
in input "1" is no of test case and "104382426112" is "n" value — Hari Kiran Vusirikala, Mar 03 '17 at 13:52
"Possible duplicate" does not mean that your code is from someone else, it means that your question/problem was posted already — Pascal Schneider, Mar 03 '17 at 14:06

score 2 · Accepted Answer · answered Mar 03 '17 at 14:12

The only problem I can see is that this code won't work for numbers greater than Integer.MAX_VALUE ... which is 2,147,483,647. That's 2 billion and a bit.

The reason for that limitation is that you are using int to do the integer arithmetic. Solution: use long instead.

Number to Words

1 Answers1