Disable button click : only when field is empty

Question

this Question is different because this is using api data to intent and then if you use normal if else condition its not working . check the right answer below and the condition of it ----------

hi, I'm trying to get android call service to a button click ,button is inside a ListView when I click one list item it goes to single item view in that single item view each single item has a mobile number attached to call button . Numbers are stored in parse data base and i'm calling using parse api .

Now when I'm clicking a number it goes to call function . what I need is, suppose a single view doesn't have a mobile number , the button should not be clickable.If anyone knows please help me.

edited answer as one of below anwer but this also not working

btn = (Button) findViewById(R.id.button56) ;
                btn.setClickable(false);

                btn.setOnClickListener(new View.OnClickListener() {

                    @Override
                    public void onClick(View v) {


                        String phno = object.getString("telephone");
                        Intent i=new Intent(Intent.ACTION_DIAL,Uri.parse("tel:" +phno));
                        startActivity(i);
                    }
                });

Below is my code

btn = (Button) findViewById(R.id.button56) ;
            btn.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {


                    String phno = object.getString("telephone");
                    Intent i=new Intent(Intent.ACTION_DIAL,Uri.parse("tel:" +phno));
                    startActivity(i);
                }
            });

this is different please check it . @Rotwang – Faizal Munna Mar 05 '17 at 17:25 — Faizal Munna, Mar 05 '17 at 17:25

Chetan Joshi · Accepted Answer · 2017-03-05T13:39:59.987

3

You can check and set your button enable to false , also clickable false, and you can and set above status to button within getView() of your Adapter so its pre disable if your mobile number field are empty in your data List

mButton.setClickable(false);
mButton.setEnabled(false);

put below code before you are adding Click Listener to button.

    mButton = (Button) findViewById(R.id.button56) ;
    String phno = object.getString("telephone");

    if(phno==null || phno.equals("")){
        mButton.setClickable(false);
        mButton.setEnabled(false);
    }
else{
        mButton.setEnabled(true);
        mButton.setClickable(true);
}

edited Mar 05 '17 at 13:39

answered Mar 05 '17 at 13:04

Chetan Joshi

5,582
4
30
43

can you provide get view code also i didnt understand that part – Faizal Munna Mar 05 '17 at 13:05
if you have Listview then When you set phone data in your adapter ,So while you are set phone number to button then place one if condition for empty string and if your string is empty then disable your button. – Chetan Joshi Mar 05 '17 at 13:09
see my updated answer.@FaizalMohamed – Chetan Joshi Mar 05 '17 at 13:14
setEnable is in read "cannot resolve method" error – Faizal Munna Mar 05 '17 at 13:16
setEnabled() use this method name was wrong – Chetan Joshi Mar 05 '17 at 13:19
app crashes and Process: app.com.anew.fbcapplication5, PID: 12093 java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference error message – Faizal Munna Mar 05 '17 at 13:21
put check for null too. – Chetan Joshi Mar 05 '17 at 13:28
see mu updated answer i have added condition for null check for too. – Chetan Joshi Mar 05 '17 at 13:30
nul also crashing java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference this error showing – Faizal Munna Mar 05 '17 at 13:31
i Added your modified answer it is working on button al the time when there is number also button is not clickable – Faizal Munna Mar 05 '17 at 13:34
Then Add else condition too and enable and clickable by passing true into button. – Chetan Joshi Mar 05 '17 at 13:36
ok .can you send me code to put inside else please – Faizal Munna Mar 05 '17 at 13:38
I added a blank else condtion but stil button is disabled all the time – Faizal Munna Mar 05 '17 at 13:39
see my updated code. – Chetan Joshi Mar 05 '17 at 13:40
I added it always not editable – Faizal Munna Mar 05 '17 at 13:46
pelase check in else having true set on both methods – Chetan Joshi Mar 05 '17 at 13:55
thnaks @Chetan working fine :) – Faizal Munna Mar 05 '17 at 17:19
please check this link http://stackoverflow.com/questions/42468580/android-geo-location-using-intent @Chetan – Faizal Munna Mar 05 '17 at 19:14

Zoe · Answer 2 · 2017-03-05T13:46:25.973

One way to go at it is using Button.setClickable

Button button;//initialize, add onClickListener, styling, whatever you need
button.setClickable(true/false);//This is what sets it clickable/unclickable

So see if there is a number/value present(if you are using EditText or something else that requires input) and setClickable true or false depending on if there is a value or not

And to make sure there is a value, add to the onClickListener:

String string = editText.getText();
if(string.equals("")){
    //throw exception, show toast, whatever you feel like doing in the event that the button is pressed in an unclickable state
    return;
}

Example integration

    Button btn;//initialize, set listeners, etc
    btn.setClickable(false);//edittext has no input initially, so set the button as unclickable
    EditText et;//initialize
    et.addTextChangedListener(new TextWatcher() {

        @Override
        public void afterTextChanged(Editable s) {}

        @Override
        public void beforeTextChanged(CharSequence s, int start,
                                      int count, int after) {
        }

        @Override
        public void onTextChanged(CharSequence s, int start,
                                  int before, int count) {
            //s is the input in form of a charsequence that has a length for each char. Meaning if it isn't 0, there is input and the button is clickable. If it is 0, there is no text and the button should not be clickable
            if(s.length() != 0)
                btn.setClickable(true);
            else
                btn.setClickable(false);
        }
    });

hi thanks ., can you give full code i mean can tyou impliment in my question please .. I'm novice developer unable to impliment your code in mine — Faizal Munna, Mar 05 '17 at 13:37
Stackoverflow is a site for help with specific problems. Integrating is for you to handle. This site is not a code writing service — Zoe, Mar 05 '17 at 13:58
ok sory ..but i dont think i can impliment your code in my code anyway thanks for help — Faizal Munna, Mar 05 '17 at 16:32

BR89 · Answer 3 · 2017-03-05T13:10:25.753

1

Sounds like you will need to evaluate this before the onClick event.

Setup a boolean and evaluate if the field has data. Then use btn.setClickable(false); if the statement comes back as false.

edited Mar 05 '17 at 13:10

answered Mar 05 '17 at 12:51

BR89

716
1
6
23

btn = (Button) findViewById(R.id.button56) ; btn.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { btn.setClickable(false); String phno = object.getString("telephone"); Intent i=new Intent(Intent.ACTION_DIAL,Uri.parse("tel:" +phno)); startActivity(i); } }); – Faizal Munna Mar 05 '17 at 13:03
I added this but still empty is working – Faizal Munna Mar 05 '17 at 13:04
Comments codes are hard to read :P looks like you set the clickable inside the onClick event. Evaluate the setClickable prior to your onClick. Otherwise you're still executing the rest of the code in the onClick event – BR89 Mar 05 '17 at 13:05
i did that also but not working empty also showing – Faizal Munna Mar 05 '17 at 13:07
Can you edit your initial question with the new code? Hard to tell from comments. – BR89 Mar 05 '17 at 13:08
By empty also showing do you mean it's still clickable or that it is visible? – BR89 Mar 05 '17 at 13:14
if the phone number is empty in database also button is working ,, I need if the number is empty button should not be clickable or a toast .. – Faizal Munna Mar 05 '17 at 13:17
btn.setEnabled(false); try this instead of Clickable – BR89 Mar 05 '17 at 13:20
Process: app.com.anew.fbcapplication5, PID: 12093 java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference app crashes this error showing – Faizal Munna Mar 05 '17 at 13:22

Shubham Agarwal Bhewanewala · Answer 4 · 2017-03-05T13:03:25.997

1

btn = (Button) findViewById(R.id.button56) ;
            btn.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                    String phno = object.getString("telephone");
                    if(! phno.equals(""))
                     {

                       Intent i=new Intent(Intent.ACTION_DIAL,Uri.parse("tel:" +phno));
                    startActivity(i);
                     }
                      else
                           //generate toast here


                }
            });

I hope this helps.

edited Mar 05 '17 at 13:03

answered Mar 05 '17 at 12:52

Shubham Agarwal Bhewanewala

1,119
1
8
20

i added this code then app crashes :( is there anything else i need to modify @Shubham Agarwal Bhewanewala – Faizal Munna Mar 05 '17 at 13:00
I have edited the code and make sure that phno is not null – Shubham Agarwal Bhewanewala Mar 05 '17 at 13:05
please check the answer again else is not with brakect and after i aded braks when there is no number app crashes – Faizal Munna Mar 05 '17 at 13:13
see there i wrote generate Toast there and a single line statment doesnot need bracket. try debugging each line to check which line causes crash. And there is nothing wrong with code. if still not found check stack trace in logcat – Shubham Agarwal Bhewanewala Mar 05 '17 at 13:18
ok i'll try now – Faizal Munna Mar 05 '17 at 13:19
I tried to putt toast but get activity is in red and could not add insdie else .can you help me – Faizal Munna Mar 05 '17 at 13:35
Toast.makeText(getContext(),"some string", Toast.LENGTH_SHORT).show(); or Toast.makeText(getApplicationContext(),t.getText().toString(), Toast.LENGTH_SHORT).show(); – Shubham Agarwal Bhewanewala Mar 05 '17 at 13:46
cannot resolve method getcontext error is showing – Faizal Munna Mar 05 '17 at 13:47

Disable button click : only when field is empty

4 Answers4