getting error when passing data from one activity to another activity

Question

I am sending data from one activity to another activity . but getting error null pointer exception and app is crashed.

Error-

E/AndroidRuntime: FATAL EXCEPTION: main
                  Process: com.a98fit.neeraj.a98fit, PID: 31167
                  java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.os.BaseBundle.getString(java.lang.String)' on a null object reference
                      at com.a98fit.neeraj.a98fit.Signup$1.onClick(Signup.java:118)
                      at android.view.View.performClick(View.java:5612)
                      at android.view.View$PerformClick.run(View.java:22285)
                      at android.os.Handler.handleCallback(Handler.java:751)
                      at android.os.Handler.dispatchMessage(Handler.java:95)
                      at android.os.Looper.loop(Looper.java:154)
                      at android.app.ActivityThread.main(ActivityThread.java:6123)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757)
Application terminated.

one activity- i am storing data token & userId in database and sending to another activity via intent.

 Intent intent1 = new Intent(Name.this, Signup.class);
                            intent1.putExtra("userId", userId);
                            intent1.putExtra("token",token);
                            startActivity(intent1);

Another activity - where i am getting

Bundle bundle = getIntent().getExtras();
String token = bundle.getString("token").toString();
String userId= bundle.getString("userId");

one activity---

public class Name extends AppCompatActivity {
        private static final String TAG = Name.class.getSimpleName();

        private Button btn_name_next;
        EditText emailid,editTextUserName;
        private ProgressDialog pDialog;
        private SessionManager session;
        private SQLiteHandler db;
        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_name);
            btn_name_next = (Button) findViewById(R.id.btn_name_next);

            editTextUserName=(EditText) findViewById(R.id.editTextUserName);
            final TelephonyManager tm = (TelephonyManager) getBaseContext().getSystemService(Context.TELEPHONY_SERVICE);

            final String tmDevice, tmSerial, androidId;
            tmDevice = "" + tm.getDeviceId();
            tmSerial = "" + tm.getSimSerialNumber();
            androidId = "" + Settings.Secure.getString(getContentResolver(), Settings.Secure.ANDROID_ID);

            UUID deviceUuid = new UUID(androidId.hashCode(), ((long) tmDevice.hashCode() << 32) | tmSerial.hashCode());
            final String deviceId = deviceUuid.toString();
            Log.e(TAG, "Device Id: " + deviceId);
            // Progress dialog
            pDialog = new ProgressDialog(this);
            pDialog.setCancelable(false);

            // Session manager
            session = new SessionManager(getApplicationContext());

            // SQLite database handler
            db = new SQLiteHandler(getApplicationContext());

            // Check if user is already logged in or not
            if (session.isLoggedIn()) {
                // User is already logged in. Take him to main activity
                Intent intent = new Intent(Name.this,
                        MakemeHealthy.class);
                startActivity(intent);
                finish();
            }



            btn_name_next.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {




                    String name=editTextUserName.getText().toString();

                    if (name.length()==0) {

                        editTextUserName.setError("Tell us your name atleast");

                    }


                    else
                    {
                        //launchAgeScreen();
                        registerUser(name, deviceId);

                    }
                }
            });
        }

        private void registerUser(final String name, final String deviceId) {


                // Tag used to cancel the request
                String tag_string_req = "req_register";

                pDialog.setMessage("Registering ...");
                showDialog();

                StringRequest strReq = new StringRequest(Request.Method.POST,
                        AppConfig.NAME_REGISTER, new Response.Listener<String>() {

                    @Override
                    public void onResponse(String response) {
                        Log.d(TAG, "Register Response: " + response.toString());
                        hideDialog();

                        try {
                            JSONObject jObj = new JSONObject(response);
                            boolean success = jObj.getBoolean("success");
                            //boolean error = jObj.getBoolean("error");
                            if (success) {
                                // User successfully stored in MySQL
                                // Now store the user in sqlite
                                //String uid = jObj.getString("uid");

                                String userId =jObj.getString("userId");
                                String token = jObj.getString("token");

                                db.addUser( token,userId);
                                //db.addUser(userId);
                                Intent intent1 = new Intent(Name.this, Signup.class);
                                intent1.putExtra("userId", userId);
                                intent1.putExtra("token",token);
                                startActivity(intent1);
                                Log.e(TAG, "token: " + token);
                                Log.e(TAG, "userId: " + userId);

                                Toast.makeText(getApplicationContext(), "User successfully registered. Try login now!", Toast.LENGTH_LONG).show();

                                // Launch login activity
                                Intent intent = new Intent(
                                        Name.this,
                                        Signup.class);
                                startActivity(intent);
                                finish();
                            } else {

                                // Error occurred in registration. Get the error
                                // message
                                String errorMsg = jObj.getString("error_msg");
                                Toast.makeText(getApplicationContext(),
                                        errorMsg, Toast.LENGTH_LONG).show();
                            }
                        } catch (JSONException e) {
                            e.printStackTrace();
                        }

                    }
                }, new Response.ErrorListener() {

                    @Override
                    public void onErrorResponse(VolleyError error) {
                        Log.e(TAG, "Registration Error: " + error.getMessage());
                        Toast.makeText(getApplicationContext(),
                                error.getMessage(), Toast.LENGTH_LONG).show();
                        hideDialog();
                    }
                }) {

                    @Override
                    protected Map<String, String> getParams() {
                        // Posting params to register url
                        Map<String, String> params = new HashMap<String, String>();
                        params.put("name", name);
                        //params.put("email", email);
                       // params.put("password", password);
                        params.put("deviceId", deviceId);


                        return params;
                    }

                };

                // Adding request to request queue
                AppController.getInstance().addToRequestQueue(strReq, tag_string_req);
        }

another activity- where i am sending data .

protected void onCreate(Bundle savedInstanceState) {
        //ActivityCompat.requestPermissions(this, new String[]{android.Manifest.permission.READ_PHONE_STATE}, 1);



       /* if(b!=null)
        {
            String token =(String) b.get("token");
            String userId = (String) b.get("userId");
           // Textv.setText(j);
        }*/
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_signup);
        TextView textViewlaer = (TextView) findViewById(R.id.textViewlater);
        btn_name_make = (Button) findViewById(R.id.btn_name_make);
        editTextEmailid = (EditText) findViewById(R.id.editTextEmailid);
        passwordentry = (EditText) findViewById(R.id.passwordentry);
        final TelephonyManager tm = (TelephonyManager) getBaseContext().getSystemService(Context.TELEPHONY_SERVICE);

        final String tmDevice, tmSerial, androidId;
        tmDevice = "" + tm.getDeviceId();
        tmSerial = "" + tm.getSimSerialNumber();
        androidId = "" + Settings.Secure.getString(getContentResolver(), Settings.Secure.ANDROID_ID);

        UUID deviceUuid = new UUID(androidId.hashCode(), ((long) tmDevice.hashCode() << 32) | tmSerial.hashCode());
        final String deviceId = deviceUuid.toString();
        Log.e(TAG, "Device Id: " + deviceId);
        // Progress dialog
        pDialog = new ProgressDialog(this);
        pDialog.setCancelable(false);

        // Session manager
        session = new SessionManager(getApplicationContext());

        // SQLite database handler
        db = new SQLiteHandler(getApplicationContext());

        // Check if user is already logged in or not
        if (session.isLoggedIn()) {
            // User is already logged in. Take him to main activity
            Intent intent = new Intent(Signup.this,
                    MakemeHealthy.class);
            startActivity(intent);
            finish();
        }

        // Make Me Awesome Button Click event
        btn_name_make.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                String email = editTextEmailid.getText().toString();
                String password = passwordentry.getText().toString();

                Bundle bundle = getIntent().getExtras();
                String token = bundle.getString("token").toString();
                String userId= bundle.getString("userId");
                Log.e(TAG, "token: " + token);
                Log.e(TAG, "userId: " + userId);

                if (email.length() == 0) {

                    editTextEmailid.setError("Please Enter Email id");

                } else if (!Patterns.EMAIL_ADDRESS.matcher(email).matches())

                {
                    editTextEmailid.setError("Please enter Valid Email id");

                } else if (password.length() == 0) {

                    passwordentry.setError("Please Enter password");

                } else if (password.length() < 6) {

                    passwordentry.setError("Please Enter minimum 6 character");
                } else {

                    registerUser(token,userId,email,password);
                }


            }
        });


        // I'll do it later Button Click event
        textViewlaer.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent doitlater = new Intent(Signup.this, Name.class);
                startActivity(doitlater);

            }
        });
        // ATTENTION: This was auto-generated to implement the App Indexing API.
        // See https://g.co/AppIndexing/AndroidStudio for more information.
        client = new GoogleApiClient.Builder(this).addApi(AppIndex.API).build();
    }

intent1.putExtra("token",token); is your token is String value? — Dharmbir Singh, Mar 07 '17 at 07:25
Possible duplicate of [What is a NullPointerException, and how do I fix it?](http://stackoverflow.com/questions/218384/what-is-a-nullpointerexception-and-how-do-i-fix-it) — Soham, Mar 07 '17 at 07:41

Dharmbir Singh · Accepted Answer · 2017-03-07T08:47:40.903

You made mistake here

startActivity(intent);

You put intent value in intent and start activity is intent1. So please pass intent1 instead of intent

startActivity(intent1);// pass this intent1

Use this code

                            Intent intent1 = new Intent(Name.this, Signup.class);
                            intent1.putExtra("userId", userId);
                            intent1.putExtra("token",token);
                            startActivity(intent1);
                            Log.e(TAG, "token: " + token);
                            Log.e(TAG, "userId: " + userId);

                            Toast.makeText(getApplicationContext(), "User successfully registered. Try login now!", Toast.LENGTH_LONG).show();
                            startActivity(intent1);

score 1 · Answer 2 · answered Mar 07 '17 at 07:26

1

Your Bundle is null :

try this: in Second activity to get Data

 Intent i = getIntent();
String id = i.getStringExtra("userId");
String token = i.getStringExtra("token");

answered Mar 07 '17 at 07:26

rafsanahmad007

23,683
6
47
62

score 1 · Answer 3 · answered Mar 07 '17 at 07:27

You have called Signup Actvity twice in your code see below code in your code.

Intent intent1 = new Intent(Name.this, Signup.class);
intent1.putExtra("userId", userId);
intent1.putExtra("token",token);
startActivity(intent1);
Log.e(TAG, "token: " + token);
Log.e(TAG, "userId: " + userId);

Toast.makeText(getApplicationContext(), "User successfully registered. Try login now!", Toast.LENGTH_LONG).show();

// Launch login activity
Intent intent = new Intent(Name.this,Signup.class);
startActivity(intent);
finish();

Remove code below your Toast message in your code. like below code:

// Launch Signup activity
Intent intent1 = new Intent(Name.this, Signup.class);
intent1.putExtra("userId", userId);
intent1.putExtra("token",token);
startActivity(intent1);
Log.e(TAG, "token: " + token);
Log.e(TAG, "userId: " + userId);

Toast.makeText(getApplicationContext(), "User successfully registered. Try login now!", Toast.LENGTH_LONG).show();
finish();

score 0 · Answer 4 · answered Mar 07 '17 at 07:44

0

For not showing NullPointerException Error try like this:

Bundle bundle = getIntent().getExtras();
if(bundle !=null){
String token = bundle.getString("token").toString();
String userId= bundle.getString("userId");
}

answered Mar 07 '17 at 07:44

singh.indolia

1,292
13
26

getting error when passing data from one activity to another activity

4 Answers4