Performance issue with unitOfwork

Question

I have implemented a unitOfwork pattern that let me handle all the process of consulting the db, but I have been getting some perfomace issues. ex.

public Task<IEnumerable<BooksQueryResult>> GetBooks(int idBook, string Title, string Author)
{
   List<SqlParameter> sqlParams = new List<SqlParameter>();
        sqlParams.Add(new SqlParameter("idBook", queryParams.IdBook?? SqlString.Null));
        sqlParams.Add(new SqlParameter("Title", queryParams.Title?? SqlString.Null));
sqlParams.Add(new SqlParameter("Author", queryParams.Author?? SqlString.Null));


        return repos.DbSqlQueryAsync("EXEC usp_getValidBooks @IdBook, @Title, @Author, @DisclosurePeriod
                                               , sqlParams.ToArray());
}

It is supposed to return more than 20k records, but it takes almost 4 min.

Thanks

It is an sql query that takes 3s in running, I also checked the store procedure perfomance. Thanks — J. B, Mar 08 '17 at 22:32

score 0 · Accepted Answer · edited May 23 '17 at 11:46

0

I believe this performance could be due to using Async method.

Async method can have performance issue when reading a large column from the server (such as varbinary(MAX), varchar(MAX), nvarchar(MAX) or XML).

You can find rducom answer which explains in detail the issue with async method here

edited May 23 '17 at 11:46

Community

1
1

answered Mar 09 '17 at 19:01

Jonathan Magnan

10,874
2
38
60

Excellent recommendation! – J. B Mar 16 '17 at 20:58

Performance issue with unitOfwork

1 Answers1