43

I want to use the @Value annotation to inject a Double property such as:

@Service
public class MyService {

    @Value("${item.priceFactor}")
    private Double priceFactor = 0.1;

// ...

and using Spring property placeholder (Properties files):

item.priceFactor=0.1

I get Exception:

org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'java.lang.Double'; nested exception is java.lang.NumberFormatException: For input string: "${item.priceFactor}"

Is there a way to use a Double value coming from a properties file?

guilhebl
  • 8,330
  • 10
  • 47
  • 66

6 Answers6

84

Try changing the following line

@Value("${item.priceFactor}")

to

@Value("#{new Double('${item.priceFactor}')}")
bcr666
  • 2,157
  • 1
  • 12
  • 23
7

This should solve the problem-

@Value("#{T(Double).parseDouble('${item.priceFactor}')}")
private Double priceFactor;
alex.b
  • 1,448
  • 19
  • 23
pkoli
  • 646
  • 8
  • 21
  • int is primitive.. Try the object Integer – Joe Mar 31 '20 at 23:16
  • I was able to make this work with a primitive Long, and I think this should be a part of the accepted answer since addition of `T(Double)` instead of `Double` is the real catch here and hard to be found intuitively. Thank you for this answer. – alegria Dec 07 '21 at 11:20
1

I had a similar problem but instead of required type 'java.lang.Double' it was required type 'java.lang.Long'. I was using env. variables from a YAML file. Turns out YAML doesn't support the Long data type.

Omar YAYA
  • 664
  • 6
  • 7
1

Below logic works for me without using new Double:

@Value("${item.priceFactor}")
private Double priceFactor;

item.priceFactor=0.1

Spring will automatically convert for you.

Coder17
  • 767
  • 4
  • 11
  • 30
0

You forgot the @PropertySource annotation with the name of the properties file as parameter.

It should come before or after your @Service annotation.

Please have a look for a working solution with @Configuration (the super type of @Service) at https://github.com/bojanantonovic/spring-properties-demo.

-2

How about storing a String and converting to numbers like integers and doubles through getters and setters? For safe code with Java injection you should always use getters and setters and only for other methods in any case. I advice you warmly to read about java security (Which is NOT for hackers), but more for code usage and writing likewise the one you uploaded, wich uses injection.

Vitali Pom
  • 602
  • 1
  • 8
  • 29