Condensing If Statement Batch File

Question

I have this batch script that has numerous "if statements". Here are a couple lines of what I have:

if %c%==PC exit
if %c%==pc exit
if %c%==CMD exit
if %c%==cmd exit
if %c%==MENU exit
if %c%==menu exit
if %c%==KILL exit
if %c%==kill exit

There are many more possibilities and really could use some simplifying if it is possible. So is there a way I can simplify this? Perhaps something like, if the variable c is equal to any of these exit. Or even make the if statements case insenstitive Is this possible? Really, any way to simplify this would be awesome and could greatly reduce the size of my batch script.

A couple side notes

This code already works and does not need to be edited with the exception of condensing it.
I know there is a similar question found here, but I do not know how to apply it to my problem.

Open up a cmd prompt and type: `IF /?`. I bet there is an option in there that will help you. — Squashman, Mar 11 '17 at 13:57

Aacini · Answer 1 · 2017-03-11T17:08:55.080

This is the shortest method:

rem Next line is necessary to nest the value of one variable inside another one
setlocal EnableDelayedExpansion

rem Initialize the list of values enclosed by slash
set "values=/PC/CMD/MENU/KILL/"



if /I "!values:/%c%/=!" neq "%values%" exit

The initialization of values variable just needs to made it once, at beginning
The !values:/%c%/=! part first replaces the %c% variable; then try to remove such a value enclosed by slashes from !values! variable using Delayed Expansion.
If the result is different than the original %values% variable, it means that /%c%/ string appears inside !values!. In this case, execute exit.
The /I switch in if command checks for both uppercase and lowercase (and any other letters combination) in %c%.

This method also allows to insert an else part in the if command in the simplest way, because there is just one if.

EDIT: As user LotPings indicated, it is not necessary to include the /I switch in this case because in the %var:old=new% replacement, the old string replacement from %var% value is case insensitive.

The `/i` switch isn't necessary here. The string replacement is case insensitive and the remaining part of value will have the same casing as the complete value. +1 for the solution. — , Mar 11 '17 at 15:37

score 2 · Accepted Answer · answered Mar 11 '17 at 14:17

2

From the HELP for the IF command. The /I switch, if specified, says to do case insensitive string compares. The /I switch can also be used on the string1==string2 form of IF.

if /I %c%==PC exit
if /I %c%==CMD exit
if /I %c%==MENU exit
if /I %c%==KILL exit

answered Mar 11 '17 at 14:17

Squashman

13,649
5
27
36

so if I use `/I` then I won't need to check for both `PC` and `pc`, right? – Christian Sirolli Mar 11 '17 at 14:19
1

@BaliC, well in my world 4 is less than 8. – Squashman Mar 11 '17 at 14:21
This works. I am using both your answer and the first answer. Both are helpful to me, for both helped me condense my script. I don't know who to choose as the best answer – Christian Sirolli Mar 11 '17 at 14:22
@AChildofGod, if you use the /I switch in BaliC's code you just need one instance of each word to check. `for %%a in (pc cmd menu kill) do if /I %c%==%%a exit` – Squashman Mar 11 '17 at 14:25

Bali C · Answer 3 · 2017-03-11T14:15:34.037

1

You can use an array:

set arr=PC pc CMD cmd MENU menu KILL kill
for %%a in (%arr%) do (
if %c%==%%a exit
)

For multiple values, replace the if line with:

if %c%=="PC" if %c%=="pc"

It will only run the next line if all if's are true.

edited Mar 11 '17 at 14:15

answered Mar 11 '17 at 13:58

Bali C

30,582
35
123
152

One other thing. Is it possible to use two optional values that result in the same thing in one if statement? – Christian Sirolli Mar 11 '17 at 14:05
Basically condensing this: `if %c%==PC start PC.bat` `if %c%==pc start PC.bat` – Christian Sirolli Mar 11 '17 at 14:05
1

Are either one of you going to read the help file for the `IF` command? – Squashman Mar 11 '17 at 14:07
@AChildofGod You could chain the `if`'s together in one line, that would be the equivelant of an `or` – Bali C Mar 11 '17 at 14:11
1

@Squashman Why don't you post an answer then if it's all in the help file? – Bali C Mar 11 '17 at 14:11
@BaliC how would you chain them together? and what do you mean by "chain"? – Christian Sirolli Mar 11 '17 at 14:12
@Squashman I'm trying to read the help file, it is somewhat confusing. So much information, and I am just sifting through it to find what I need – Christian Sirolli Mar 11 '17 at 14:13
@AChildofGod See my updated answer, if you are just running files though it shouldn't be a problem as the files will be case insenstive. – Bali C Mar 11 '17 at 14:16
@BaliC that last bit didn't work for me. Thanks for the array idea. – Christian Sirolli Mar 11 '17 at 14:23
1

Just a suggestion: `for %%a in (pc cmd menu kill) do if /I %c%==%%a exit` . One line of code. – Squashman Mar 11 '17 at 14:26
1

@AChildofGod, it is not an array. It is just a string. There is no array type variable in batch-files. It can be simulated though. – Squashman Mar 11 '17 at 14:28
@Squashman Good idea, as long as you aren't adding more words that one liner works nicely and is still readable – Bali C Mar 11 '17 at 14:29
@Squashman and BaliC thanks for the quick responses. I was sort of expecting answers later today. – Christian Sirolli Mar 11 '17 at 14:32
@AChildofGod No probs :) – Bali C Mar 11 '17 at 14:33
The chain of two `if`'s together is equivalent to an `AND`, _not_ to an `OR`; for example, there is no way that `if %c%==PC if %c%==pc exit` works. This is not an array because there are not subscripts involved. – Aacini Mar 11 '17 at 15:29

Condensing If Statement Batch File

3 Answers3

Linked