Calling nested function when function name is passed as a string

Question

I'm trying to access a nested function by passing the function name in as a string and then calling it. Eg, see this post

function outer(action){
    window["outer"][action]();

    function inner(){
        alert("hello");
    }
}
outer("inner");

However it doesn't work. Error:

window.outer[action] is not a function

How to make this work, or an alternative way of calling a nested function.

The reason for this is that I am trying to hide a bunch of functions that are called by an iframe inside a functions scope.

score 6 · Accepted Answer · answered Nov 25 '10 at 14:23

6

function outer(action){
   var inner = {
     func1: function() {},
     func2: function() {},  
     func3: function() {},
     // ...
   }
   inner[action]();
}

outer("func1");

answered Nov 25 '10 at 14:23

gblazex

49,155
12
98
91

score 1 · Answer 2 · answered Nov 25 '10 at 14:24

1

In that way you are trying to access the "inner" property of the "outer" function (outer.inner) that is not defined. The only way to do that is by using eval:

function outer(action){
    eval(action+"()");

    function inner(){
        alert("hello");
    }
}
outer("inner");

But remember eval is evil is some situations so be careful.

answered Nov 25 '10 at 14:24

mck89

18,918
16
89
106

eval. urgggh. galambalazs came up with a solution. – SystemicPlural Nov 25 '10 at 14:31
1

You won't die if you use eval trust me:) – mck89 Nov 25 '10 at 14:33
1

Yeah you won't die, Crockford won't kill you he'll just torture you till the end of time :P – Ivo Wetzel Nov 25 '10 at 14:36

Calling nested function when function name is passed as a string

2 Answers2

Linked