Why boolean is not working on str?

Asked Mar 17 '17 at 00:08

Active Mar 17 '17 at 01:08

Viewed 32 times

While trying to learn Python with the online course at university of waterloo link here the rest follows:

I am trying to write a function which will consume a string, and if the first letter is equal to 'y' or 'Y', it will have a "True" boolean return. Else, it will be have a "False" output. This is my code:

def is_yes(x):
    if (x[0] == 'Y' or 'y'):
        return True
    else:
        return False

is_yes('yes')

The function has no errors and the only output is: [Finished in 0.1s]

while testing the code with adding a print() to the function call: print(is_yes('yes')) , no matter what the input, the answer is always True.

what is wrong with the code? Also, I'm trying to self-learn and there is no one to teach me, so I Hope I do not get banned because I ask stupid questions, I am just trying to learn.

edited Mar 17 '17 at 01:08

martineau

119,623
25
170
301

asked Mar 17 '17 at 00:08

1

or 'y'. 'y' is always evaluated true! – sascha Mar 17 '17 at 00:11
@sascha removed the brackets, still always True – Mar 17 '17 at 00:11
1

Yeah my bad. The or 'y' is the problem! – sascha Mar 17 '17 at 00:12
@sascha Woaa... Thats so weird. but it Works now. Thanks! – Mar 17 '17 at 00:14
It's not weird and the reason is probably explained in the duplicate-question. – sascha Mar 17 '17 at 00:16
1

@sascha yes, I just read it and it all makes sense now :) Thanks everyone! – Mar 17 '17 at 00:17
1

also instead of the (if , else) statement, it is better practice and less redundant to simply do a "return (x[0] == 'Y' or x[0] == 'y')" – Neel Sampemane Mar 17 '17 at 00:26
@NeelSampemane excuse my ignorance, but is it better practice because less lines take less memory? – Mar 17 '17 at 01:24

Why boolean is not working on str?

0 Answers0