Compare two dates in PHP not compare correctly

Question

I Want how to compare two dates

I have this

$last_day = '2017-11-01';
$end = '18/03/2017';
$last_day = date('d/m/Y', strtotime($last_day));

            if($last_day < $end){
                echo "Is closed";
            }else{
                echo "Is Open";
            }

Return "Is Close"

What happens?

what's happening here : `$last_day = date('d/m/Y', strtotime($fechas['last_day']));` — Masivuye Cokile, Mar 17 '17 at 12:27
you're overwriting `$last_day` in the second pass here. question's unclear as per other comment given up there. — Funk Forty Niner, Mar 17 '17 at 12:27
@Loko they just Stealthly [edited](http://stackoverflow.com/revisions/42857496/2) that out. — Funk Forty Niner, Mar 17 '17 at 12:28
Possible duplicate of [php - comparing two date](http://stackoverflow.com/questions/12233436/php-comparing-two-date) — Yoav Schniederman, Mar 17 '17 at 12:57

score 2 · Answer 1 · answered Mar 17 '17 at 12:26

2

You are comparing strings, not dates. Use DateTime() objects as they are comparable:

$last_day = new DateTime('2017-11-01');
$end      = DateTime::createFromFormat('d/m/Y', '18/03/2017');

if($last_day < $end){
  echo "Is closed";
}else{
  echo "Is Open";
}

If $fechas['last_day'] is in d/m/Y format you will have to change $last_day to use DateTime::createFromFormat() as well as that format will cause errors as dates using / are considered American and 18/3/2017 would be an invalid date.

answered Mar 17 '17 at 12:26

John Conde

217,595
99
455
496

*`If $fechas['last_day']`* - [See my comment...](http://stackoverflow.com/questions/42857496/compare-two-dates-in-php-not-compare-correctly#comment72821142_42857496) John. – Funk Forty Niner Mar 17 '17 at 12:31

Manish Jesani · Answer 2 · 2017-03-17T12:31:43.547

0

You are not compare two dates in date format. Please convert first in strtotime format after compare two date.

Please Try This

$last_day = '2017-11-01';
$end = strtotime('18/03/2017');
$last_day = strtotime(date('d/m/Y', strtotime($last_day)));

 if($last_day < $end){
    echo "Is closed";
 }else{
    echo "Is Open";
 }

edited Mar 17 '17 at 12:31

answered Mar 17 '17 at 12:29

Manish Jesani

1,339
5
20
36

2

Code dumps to not make for good answers. You should explain how and why this solves their problem. You should read, "[How do I write a good answer?"](http://stackoverflow.com/help/how-to-answer) – John Conde Mar 17 '17 at 12:29
@JohnConde Thank you – Manish Jesani Mar 17 '17 at 12:34

score 0 · Answer 3 · answered Mar 17 '17 at 12:30

First of all

try this

$last_day = '2017-11-01';
$end = '18/03/2017';
echo $last_day = date('d/m/Y', strtotime($fechas['last_day']));
if($last_day < $end){ echo "Is closed";}
else{ echo "Is Open";}

It will show you the correct value of $last date. And you can easily understand the problem. or You can convert both dates into timestamp and compare them.

$last_day = strtotime('2017-11-01');
$end = strtotime('18/03/2017');
$last_day = strtotime($fechas['last_day']);
if($last_day < $end){ echo "Is closed";}
else{ echo "Is Open";}

score -2 · Answer 4 · answered Mar 17 '17 at 12:31

-2

You cannot compare between string and date. Please convert both variable to date.

answered Mar 17 '17 at 12:31

FPratama

14
3

2

this is a very poor/low-quality answer. – Funk Forty Niner Mar 17 '17 at 12:34
the least you can do is to show to do the *Please convert both variable to date* – Masivuye Cokile Mar 17 '17 at 12:37
@Fred-ii- : oh, ok – FPratama Mar 17 '17 at 12:37

Compare two dates in PHP not compare correctly

4 Answers4