ASP.NET mail attachment inline

Question

I have this line of code that creates an attachment.

email.Attachments.Add(new Attachment(new MemoryStream(filebytes), "QRCode.png"));

now I am trying to apply ContentDisposition.Inline property to it....how would I do this when creating my attachment the way I did it?

Do you need solution in one line? – Darjan Bogdan Mar 21 '17 at 19:26 — Darjan Bogdan, Mar 21 '17 at 19:26

score 0 · Accepted Answer · answered Mar 21 '17 at 19:29

I suppose you want a solution in one line, this is one way of doing it:

email.Attachments.Add((new Func<Stream, Attachment>(stream => { var attachment = new Attachment(stream, "QRCode.png"); attachment.ContentDisposition.Inline = true; return attachment; }).Invoke(new MemoryStream(fileBytes))));

However, I strongly discourage this approach, it is awfully hard to read.

score 0 · Answer 2 · answered Mar 21 '17 at 19:37

@darjan-bogdan's solution would be the way to go if it absolutely needs to be one line for some reason.

However, if the goal is to just have a single-line logic statement for adding an attachment, I'd just use a helper method, à la:

Attachment data = BuildAttachment(new MemoryStream(filebytes), "QRCode.png"));
...

private Attachment BuildAttachment(MemoryStream stream, string name) {
    Attachment attachment = new Attachment(stream, name);
    attachment.ContentDisposition.Inline = true;

    return attachment;
}

This preserves your "single line" in what I assume is your for-loop.

I agree with you, code should be readable. – Darjan Bogdan Mar 21 '17 at 19:42 — Darjan Bogdan, Mar 21 '17 at 19:42

ASP.NET mail attachment inline

2 Answers2