89

I've read many things about react-router v4 and the npm history library to this point, but none seems to be helping me.

My code is functioning as expected up to the point when it should navigate and do a simple redirect when the url is changed using the history.push() method. The URL IS changing to the specified route, but not doing the redirect on the button push.

I would like for the button push to do a simple redirect without the {forceRefresh:true}, which then reloads the whole page.

import React from 'react';
import createBrowserHistory from 'history/createBrowserHistory';

const history = createBrowserHistory({forceRefresh:true});

export default class Link extends React.Component {
  onLogout() {
    history.push("/signup");
  }
  render() {
      return(
        <div>
          <h1>Your Links</h1>
          <button onClick={this.onLogout.bind(this)}>Log Out</button>
        </div>
      )
  }
}
starball
  • 20,030
  • 7
  • 43
  • 238
John
  • 1,075
  • 1
  • 7
  • 13

13 Answers13

75

You shouldn't need to downgrade to v3, React-Router 4.0.0 is totally capable of accomplishing what the OP asked for.

const history = createBrowserHistory();

is a custom history object so you should use <Router> to synchronize it with react-router instead of <BrowserRouter>, which is what I assumed you were using.

Try this instead:

import React, {Component} from 'react';
import { Router } from 'react-router';
import { Route } from 'react-router-dom';
import createHistory from 'history/createBrowserHistory';

const history = createHistory();   

class App extends Component {
   constructor(props){
      super(props);
   }
 
   render(){
       return (
           <Router history={history}>   //pass in your custom history object
                <Route exact path="/" component={Home} />
                <Route path="/other" component={Other} />
           <Router />
       )
   }
}

Once your custom history object is passed in via Router's history prop, history.push should work just as expected in anywhere of your app. (you might want to put your history object in a history config file and import it into places where you want to route programmatically).

For more info, see: React Router history object

Tina Chen
  • 939
  • 1
  • 7
  • 14
46

Check if you don't have nested BrowserRouter tags.

I had this issue on react-router v4 but I solved it after changing the app to only have the BrowserRouter at the top most level like the example below.

ReactDOM.render(
  <BrowserRouter >
    <App />
  </BrowserRouter>,
  document.getElementById('root')
);
Artur Carvalho
  • 6,901
  • 10
  • 76
  • 105
  • 3
    I have this same problem, but still no solution – Ruan Duarte Oct 04 '20 at 04:28
  • 1
    Thanks for the answer. I had several `BrowserRouter` in different modules that make up the entire app. I had to remove `BrowserRouter` tag from all the modules and keep the only one at the App level to have it working successfully. – Ritesh Jagga Feb 09 '22 at 08:29
8

Please ensure that you are using

const history = createBrowserHistory({forceRefresh:true});

not

const history = createBrowserHistory();

I was able to update the page once I added "{forceRefresh:true}"

Anupam Chaplot
  • 1,134
  • 1
  • 9
  • 22
6

import Router from react-router-dom not BrowserRouter

// index.js

    import React from "react";
    import ReactDOM from "react-dom";
    import App from "./App";
    import { Router } from "react-router-dom";
    import history from './utils/history'


    ReactDOM.render(
      <Router history={history}>
        <App />
      </Router>,
      document.getElementById("root"));

    serviceWorker.register();


// history.js 

import { createBrowserHistory } from 'history';

export default createBrowserHistory();

on other components that you need to navigate import history and push

import History from '../utils/history'

History.push('/home')

U.A
  • 2,991
  • 3
  • 24
  • 36
5

Rendering this would refresh on route change

 `ReactDOM.render(
    <AppContainer>
      <BrowserRouter children={routes} basename={baseUrl} forceRefresh={true}/>
    </AppContainer>,
    document.getElementById("react-app")
  );`

react-router-dom : 4.2.2

bathi d
  • 59
  • 1
  • 1
2

If you are using strict mode while rendering, Remove it and try again

example:

if your render method look like this

const root = ReactDOM.createRoot(
  document.getElementById('root')
);

root.render(
  <React.StrictMode>
    <App />
  </React.StrictMode>,
);

change it to this

const root = ReactDOM.createRoot(
  document.getElementById('root')
);

root.render(
  <App />,
);
Vishnu
  • 21
  • 3
0

I have the same problem.

After some search i have found this react-router issue

I have currently downgrade react-router to the v3 and i use browserHistory from the react-router package and it's work fine.

ndufreche
  • 147
  • 6
0

If you are using functional component then try to push using useHistory Hook.

import React from 'react';
import { useHistory } from "react-router-dom";

export default function Link{

  let history = useHistory();

  onLogout() {
    history.push("/signup");
  }

  return(
        <div>
          <h1>Your Links</h1>
          <button onClick={this.onLogout.bind(this)}>Log Out</button>
        </div>
      )
}
0

you can use

forceRefresh={true}

in you code inside The BrowserRouter or inside Router

0

in case somebody here with react-router-dom v6

I had the same problem and I had to downgrade to v5

and problem fixed.

Ruhith Udakara
  • 2,236
  • 1
  • 18
  • 24
0

If you don't want to change router or version you could force the page to reload after updating history.

Eg:

history.push({
    'pathname': '/signup',
    'key': 'value'
})   
document.location.reload()
leetbacoon
  • 1,111
  • 2
  • 9
  • 32
0

The feature is removed in react-router-dom v6. The best way would be to

  1. Create a state with default value of null and modify that state after async action, then
  2. Create an if statement inside of component that checks state and redirects.
  3. Add an dispatch action that resets the value of state to null
0

for using history prop, you should use Router imported from "react-router" instead of BrowserRouter imported from "react-router-dom"

then history.push('/home') works as you want.

Keval
  • 21
  • 2