Bash script for loop with if-else statement

Question

I'm trying to write a bash script that imports all users and for each account execute some action.

a="some account"
b="some account" 
#... so on

USERS = #get imported

for ACCOUNT in $USERS; do
        if ["$ACCOUNT" == "$a"] || ["$ACCOUNT" == "$b"] || ["$ACCOUNT" == "$c"] || ["$ACCOUNT" == "$d"]; then
                echo "Skipping $ACCOUNT"
        else
                echo "this"
                echo "this $ACCOUNT"
        fi
done

But there seems to be an issue. For every account, I get following:

[thisis@anaccount: not found

I've tried getting rid of single brackets and place the entire if clause into a double bracket, but that resulted in the same error.

I've also deleted the double quotation marks for each variable calls, but that doesn't seem to be the issue.

Can anybody advise?

Please take a look: http://www.shellcheck.net/ – Cyrus Mar 22 '17 at 19:25 — Cyrus, Mar 22 '17 at 19:25

score 2 · Accepted Answer · edited Mar 22 '17 at 19:54

2

You are just missing a few spaces ...

#!/bin/bash 
a="ACC_A"
b="ACC_B" 
c="ACC_C"
d="ACC_D"

USERS="ACC_A ACC_B ACC_C ACC_X ACC_Y ACC_Z" 

for ACCOUNT in $USERS; do
        if [ "$ACCOUNT" = "$a" ] || [ "$ACCOUNT" = "$b" ] || [ "$ACCOUNT" = "$c" ] || [ "$ACCOUNT" = "$d" ]; then
              echo "Skipping $ACCOUNT"
    else
              echo "this $ACCOUNT"
    fi
done

and a quick test:

$ bash accounts.sh 
Skipping ACC_A
Skipping ACC_B
Skipping ACC_C
this ACC_X
this ACC_Y
this ACC_Z

edited Mar 22 '17 at 19:54

chepner

497,756
71
530
681

answered Mar 22 '17 at 19:28

andipla

363
4
9

this, along with running it using 'bash' as opposed to 'sh' made the script work! thanks! – viviboox3 Mar 22 '17 at 19:57

Bash script for loop with if-else statement

1 Answers1