ES6 Promises return before catch

Question

How can I achieve, that the caller of saveThings() get's a precise error description (A or B). Currently, my rejection of type A get's caught in the catch() clause, thus the caller always ends up with message B...

saveThings() {
    return api.post(endpoint, data)
    .then( response => {
        if ( !response )
            reject({message: 'error of type A - faulty response'});

        resolve('all went well');
    })
    .catch( err => {
        throw new Error('error of type B - call failed');
    });
}

What are `reject` and `resolve`? – Bergi Mar 26 '17 at 14:33 — Bergi, Mar 26 '17 at 14:33

score 3 · Answer 1 · edited May 23 '17 at 12:17

3

You'll want to use .then(…, …) instead of .then(…).catch(…):

return api.post(endpoint, data).then(response => {
    if (!response)
        throw {message: 'error of type A - faulty response'};
    return 'all went well';
}, err => {
    throw new Error('error of type B - call failed');
});

edited May 23 '17 at 12:17

Community

1
1

answered Mar 26 '17 at 14:35

Bergi

630,263
148
957
1,375

score 2 · Accepted Answer · answered Mar 26 '17 at 14:37

well, it depends on when and therefore what you catch

saveThings() {
    return api.post(endpoint, data)
        .catch(err => {
            throw new Error('error of type B - call failed');
        })
        .then( response => {
            if ( !response )
                throw new Error('error of type A - faulty response');

            return 'all went well';
        });
}

or

saveThings() {
    return api.post(endpoint, data)
        .then( response => {
            if ( !response )
                throw new Error('error of type A - faulty response');

            return 'all went well';
        }, err => {
            throw new Error('error of type B - call failed');
        });
}

wich are pretty much equivalent. Only the first one creates an intermediate Promise, after the catch, wich the second one doesn't.

Thank you, also to @Bergi. The first solution of turning things around is so simple... too many trees, didn't see the forrest. — Frank N, Mar 26 '17 at 14:50

ES6 Promises return before catch

2 Answers2