PHP function not returning TRUE

Question

I am trying to create a function that will check if a user is subscribed or not, but the code doesn't work, it doesn't return TRUE even if the user is subscribed.

Here is an example of my code.

function is_subscribed($email)
{
    global $DBC;

    $result = mysqli_query($DBC,"SELECT * FROM users WHERE email = $email");

    if(mysqli_num_rows($result) > 0) {
        while($row = mysqli_fetch_array($result)) {
            if($row['subscribed'] == 'yes') { 
                return TRUE; 
            } else {
                return FALSE;
            }
        }
    }
}

$user_email = $_SESSION['email'];

if(is_subscribed($user_email)) {
    echo "YES!";
}

What comes out when doing `var_dump($row['subscribed']);` or `var_dump($row)` — JustOnUnderMillions, Apr 06 '17 at 14:54
Your query is invalid. `email` is a string. You should parameterize the query. Put an `else` and error report on `$result` and you'll see the issue. — chris85, Apr 06 '17 at 14:55
@MaheshSinghChouhan Why? If they unsubscribed the OP might not want it to be true. — chris85, Apr 06 '17 at 14:57
Also, why not just do it all in the query? `WHERE email = '$email' AND subcribed = 'yes'` then check `num_rows` — AbraCadaver, Apr 06 '17 at 15:06

Yolo · Accepted Answer · 2017-04-06T14:55:50.327

0

You need to wrap $email into quotes because it is a string. So:

SELECT * FROM users WHERE email = '$email'

edited Apr 06 '17 at 14:55

answered Apr 06 '17 at 14:54

Yolo

1,569
1
11
16

hawkeye ;-) :-) – JustOnUnderMillions Apr 06 '17 at 14:54

score 0 · Answer 2 · answered Apr 06 '17 at 15:00

0

just do few change add sigle quote

$result = mysqli_query($DBC,"SELECT * FROM users WHERE email = '$email'");

answered Apr 06 '17 at 15:00

Abanoub Makram

463
2
13

PHP function not returning TRUE

2 Answers2