What is wrong with this code in C programming language?

Asked Apr 06 '17 at 16:53

Active Apr 06 '17 at 16:53

Viewed 34 times

When compiled no compilation errors but force closes when taken input. Do i have to use double pointer? help me out please. Thank you

#include <stdio.h>

void main() {
    int *a;
    allocate(a);
    input(a);
    display(a);
}
void allocate(int *a){
    a = malloc(sizeof(int)*3);
}

void input(int *a){
    int i=0;
    for(;i<3;i++){
    scanf("%d",&a[i]);
    }
}
void display(int *a){
    int i=0;
    for(; i<3;i++){
        printf("%d",a[i]);
    }
}

asked Apr 06 '17 at 16:53

Anim Malvat

The value returned by `malloc` is lost once you exit the `allocate` function. – Eugene Sh. Apr 06 '17 at 16:54
2

One problem right off: your `allocate` function won't return the address in `a`. The argument `a` is local to the function. You need to pass `int **a` then assign `*a = malloc(sizeof(int)*3)` and call it with `allocate(&a)` from `main`. Or just make it a return value `int *allocate(void) { return malloc(sizeof(int)*3); }`. – lurker Apr 06 '17 at 16:55
oh yeah ,, what an idiot... just forgot scope.. – Anim Malvat Apr 06 '17 at 16:56
Thanks @EugeneSh. – Anim Malvat Apr 06 '17 at 16:57
Thanks @lurker for answer – Anim Malvat Apr 06 '17 at 16:58
@lurker I get the output as you suggested but i didn't understand why it didn't worked before can you explain more.. Please thanks. – Anim Malvat Apr 06 '17 at 17:02

What is wrong with this code in C programming language?

0 Answers0