?: doesn't work correctly in javascript

Question

I written the following code to change the numbers to Persian:

function farsi(x) {
    x = x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
    var a = '۰۱۲۳۴۵۶۷۸۹'; var b = ''; 
    for (var i = 0; i < x.length; i++) { 
        var c = x.charCodeAt(i); 
        b += (c >= 48 || c <= 57 ? a.charAt(c - 48) : x.charAt(i));
     }
     return b;
 }

I have used the regex for thousand seprator from How to print a number with commas as thousands separators in JavaScript which works correctly. But the separator character is not being added in this line of code:

b += (c >= 48 || c <= 57 ? a.charAt(c - 48) : x.charAt(i));

Here is the fiddle

You are missing parentheses from the condition: b += ((c >= 48 || c <= 57) ? a.charAt(c - 48) : x.charAt(i)); — Esko, Apr 07 '17 at 08:54
https://developer.mozilla.org/cs/docs/Web/JavaScript/Reference/Operators/Operator_Precedence — Pavel Pája Halbich, Apr 07 '17 at 08:54
@Pavel that link leads to the czech translation. Here it is in english: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Operator_Precedence — Fildor, Apr 07 '17 at 08:55
"Not working" is not enough information, is there an error, wrong output or what. Please explain and add [mcve] that we can run and see the problem. — Esko, Apr 07 '17 at 08:57
@Fildor thx for fix. Since this article was not translated yet and it it in english, I didn't realize that this link is supposed to be localized — Pavel Pája Halbich, Apr 07 '17 at 08:57
@Esko well not working means that the separator comma is still missing in the output. — Ashkan Mobayen Khiabani, Apr 07 '17 at 08:58
I tried it and its working it does show to comma as seperator — Beginner, Apr 07 '17 at 08:59
@Beginner in the output? the first alert is to test the regex which shows the comma. the second alert is the real output which is missing the comma. — Ashkan Mobayen Khiabani, Apr 07 '17 at 09:00

selvarajmas · Accepted Answer · 2017-04-07T13:10:20.513

5

You put || instead of &&

b += (c >= 48 && c <= 57 ) ? a.charAt(c - 48) : x.charAt(i);

see the working code https://jsfiddle.net/4qvwzs5e/2/

edited Apr 07 '17 at 13:10

answered Apr 07 '17 at 09:01

selvarajmas

1,623
13
20

?: doesn't work correctly in javascript

1 Answers1