NodeJS: break Array.some loop

Question

I have the following function that receives a JSON array templates and returns a JSON object.

The code executes the console.log. However, it always returns the null at the end of the function. Any ideas?

function getTemplate(templates, myId) {
  Object.keys(templates).some(obj => {
    if (templates[obj].id === myId) {
      console.log('HELLO');
      return templates[obj];
    }
  });
  return null;
}

template array

[
    {
        "id": 80,
        "name": "template 1"
    },
    {
        "id": 81,
        "name": "template 2"
    }
]

However, it always returns null.

`return templates[obj];` would return in the context of the `.some(function)` surely — George, Apr 10 '17 at 13:15
`.some` is not the right method to find a specific entry in an array. — Cerbrus, Apr 10 '17 at 13:15
@George: Yea, it returns a truthy value to the `.some` function, which will tell you the right template exists, only to `return null` in the end. — Cerbrus, Apr 10 '17 at 13:16
`var result = templates.find(t => t.id === myId)` ->. `result` will be the found template, or `null` if it's not found. — Cerbrus, Apr 10 '17 at 13:18
@Cerbrus `.find()` is preferred because it halts iteration when the value is found, while `.filter()` does not. — Pointy, Apr 10 '17 at 13:20

score -1 · Accepted Answer · edited Apr 10 '17 at 13:45

-1

Here is working example,

use .find instead of .some. We always expect to get one object.

function getTemplate(templates, myId) {
  return templates.find(template => template.id === myId);
}

var array =
[
    {
        "id": 80,
        "name": "template 1"
    },
    {
        "id": 81,
        "name": "template 2"
    }
]
console.log(getTemplate(array, 80));

edited Apr 10 '17 at 13:45

Cerbrus

70,800
18
132
147

answered Apr 10 '17 at 13:22

loelsonk

3,570
2
16
23

1

That's not how `.filter` works. – Cerbrus Apr 10 '17 at 13:24
@Cerbrus thanks, I've just realized that, we should use `.find` instead. I've updated my answer. – loelsonk Apr 10 '17 at 13:31

NodeJS: break Array.some loop

1 Answers1