how to get the name list from the db using function in php

Question

This is my code to get name list from the database but I am not able to get values where is the error can anyone pls help me 

// database connection where php is my database name
<?php
$con=mysql_connect("localhost","root","root");
mysql_select_db("php",$con);
?>

// html body for getting value in option

<!DOCTYPE html>
<html>
<head>
    <title></title>
</head>
<body>
<form method="post">
<select name="select" >
    <option>Select College From Here</option>
     <?php $getoptions = get_name(); ?>
    <?php foreach ($getoptions as $key => $value) { ?>
        <option><?= $value ?></option>
    <?php } ?>
</select>
<input type="submit" name="sub">

</form>

// function to get name list from the database is this query right or wong ??
<?php
function get_name(){
    $option=array();
    $query="select * From login ";
    $result=mysql_query($query);
    while($row=mysql_fetch_array($result)){
        $option [$row->id] = strtoupper($row->name);
            }
$option;
}
?>

Help me regarding this that function not returning me the name from the table and m not able to see the list on select box.. and tell me how can i see the what function is going to return how to get function return value, can i alert the return value or echo the value

FYI, [you shouldn't use `mysql_*` functions in new code](http://stackoverflow.com/questions/12859942/). They are no longer maintained [and are officially deprecated](https://wiki.php.net/rfc/mysql_deprecation). See the [red box](http://php.net/manual/en/function.mysql-connect.php)? Learn about [*prepared statements*](https://en.wikipedia.org/wiki/Prepared_statement) instead, and use [PDO](http://php.net/pdo) or [MySQLi](http://php.net/mysqli) - [this article](http://php.net/manual/en/mysqlinfo.api.choosing.php) will help you decide which one is best for you. — John Conde, Apr 17 '17 at 12:53
You don't know what's wrong because you don't check for errors in your code. Never assume the code is always going to work flawlessly. Use [`mysql_error()`](http://php.net/manual/en/mysql.error.php) to get a detailed error message from the database. — John Conde, Apr 17 '17 at 12:53
You're fetching data as an array and then trying to access it as an object. If you turned on error reporting PHP would have warned you about this. — John Conde, Apr 17 '17 at 12:54

Shafiqul Islam · Accepted Answer · 2017-04-17T13:15:33.930

1

try this but not tested

   function get_name()
{
// your code
    while($row=mysql_fetch_array($result)){
        $id = $row['id'];
        $option [$id] = strtoupper($row['name']);
    }
    return $option;

}

check this for test

while ($row = mysqli_fetch_assoc($result)) {
        $id = $row['id'];
        echo $id . "==" . $row['name'];
        echo "<br>";

        $option [$id] = strtoupper($row['name']);
    }
    $option;
    print_r($option);

edited Apr 17 '17 at 13:15

answered Apr 17 '17 at 12:58

Shafiqul Islam

5,570
2
34
43

check last section for testing if everything fine – Shafiqul Islam Apr 17 '17 at 13:10
i think you missed return $option. so please check now – Shafiqul Islam Apr 17 '17 at 13:15
function get_name(){ $con=mysql_connect("localhost","root","root"); mysql_select_db("php",$con); $option=array(); $query="select name from login"; $result = mysql_query($query); while ($row = mysql_fetch_assoc($result)) { foreach ($row as $value) { $option [$value['id']] = $value['name']; } } return $option; } i used this code it returning the value but only first charecter not whole string like gaurav in db its returning g only – Gaurav Pandey Apr 17 '17 at 13:20
this is separate function – Shafiqul Islam Apr 17 '17 at 13:21
– Shafiqul Islam Apr 17 '17 at 13:22
is it work? if work then no need db connection in function – Shafiqul Islam Apr 17 '17 at 13:24
thanx its working now can u pls explain y i need to put query like this $query="select name,id from login"; without is its not wrking why – Gaurav Pandey Apr 17 '17 at 13:27
– Shafiqul Islam Apr 17 '17 at 13:29
check this , i think it will work without db connection in function , if work then inform me, i will tell you details – Shafiqul Islam Apr 17 '17 at 13:30
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/141892/discussion-between-shafiqul-islam-and-gaurav-pandey). – Shafiqul Islam Apr 17 '17 at 13:30
http://chat.stackoverflow.com/rooms/141892/discussion-between-shafiqul-islam-and-gaurav-pandey – Shafiqul Islam Apr 17 '17 at 13:31

score 0 · Answer 2 · answered Apr 17 '17 at 13:31

0

should replace this

while($row=mysql_fetch_array($result)){
   $option [$row->id] = strtoupper($row->name);
        }

$option;

by this code

while($row=mysql_fetch_array($result)){
    $option [$row['id']] = strtoupper($row['name']);
        }

return $option;

answered Apr 17 '17 at 13:31

Gandhivasan

11
3

Why should the OP "replace" this? A ***good answer*** will always have an explanation of what was done and why it was done in such a manner, not only for the OP but for future visitors to SO. – Jay Blanchard Apr 17 '17 at 13:58

how to get the name list from the db using function in php

2 Answers2