How to insert to a database with foreach?

Question

Hi a have a small problem. I can't insert into db array... this is my code

$qurum1 = implode('|',$_POST['qurum1']);
$qurum = explode('|', $qurum1);
foreach ($qurum as $value) {
$query2 = "INSERT INTO test (data_id, col2) VALUES ('$id', '$value')"; 
}

This code inserts only last value

I recommend not to run queries inside of loops, you should probably create one INSERT statement which inserts all of the values at once. Also you are open to SQL injection, have a look at [this](http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php?rq=1) SO question. — Tobias F., Apr 19 '17 at 11:07
check - http://php.net/manual/en/mysqli.quickstart.multiple-statement.php — Bhaskar Jain, Apr 19 '17 at 11:09
your comments are all but useful. @Jabbar look at this link: https://www.w3schools.com/php/php_mysql_insert.asp . You can find useful info about how to insert data to database. good for the beginning — boroboris, Apr 19 '17 at 11:10
@Jens Because when you run queries within a loop this can have an impact on the performance, so your code will run slower. — Tobias F., Apr 19 '17 at 11:11
@Jens - because you uneccesarily call database multiple times, and the most expensive part of executing a query is connecting to database — boroboris, Apr 19 '17 at 11:11
_“your comments are all but useful”_ ... said the person linking to w3schools. Oh, the irony. — CBroe, Apr 19 '17 at 11:13
why are you executing query multiple times just grab the values inside loop and insert in one single shot. — vishu, Apr 19 '17 at 11:14
One has to wonder where the OP is with all this. Seems like this is an *"argue amongst your/ourselves"*. — Funk Forty Niner, Apr 19 '17 at 11:15
linking w3schools to a person who asks how to execute simple query. it is enough if you're a beginner. — boroboris, Apr 19 '17 at 11:17
@Akin No need to hold that weight on *your* shoulders. I edited my comment up there btw ;-) see the latter. — Funk Forty Niner, Apr 19 '17 at 11:18
Then there's the POST's origin and if it is in fact an array and the api used to connect with is unknown. — Funk Forty Niner, Apr 19 '17 at 11:21
I need every time new row. I do not need all values in one row — Jabbar Guliyev, Apr 19 '17 at 11:26
can't you create a new merged array which contains the data_id and col_2 values. Then use that array in your foreach loop so the value of id does not repeat itself. — Rotimi, Apr 19 '17 at 11:29

Ashok · Answer 1 · 2017-04-19T12:22:19.577

0

Try this

<form method="post">
    <input id="value1" value="value1"  name="qurum1[]" type="checkbox">
    <input id="value2" value="value2"  name="qurum1[]" type="checkbox">
    <input value="21"  name="id" type="hidden">
    <input type="submit">
</form>

<?php
    if(isset($_POST['qurum1'])){
        $invite = $_POST['qurum1'];
        $id = $_POST['id'];
        $dbObj=mysqli_connect("$dbhost","$dbusername","$dbpasswd","$dbname") or die('Could not connect to DB : ' .mysqli_connect_error());
        foreach ($qurum as $value) {
            $query2 = "INSERT INTO test (data_id, col2) VALUES ('$id', '$value')"; 
            $ins_sql = mysqli_query($dbObj,$query2);
        }
    }
?>

Now i have added the 'id' as hidden element.

edited Apr 19 '17 at 12:22

answered Apr 19 '17 at 11:42

Ashok

128
1
8

I have changed the code with mysqli_connect() – Ashok Apr 19 '17 at 11:47
I already have all $vars, I just need the $qurum array correctly insert to db – Jabbar Guliyev Apr 19 '17 at 11:48
Please post the data in $qurum variable. – Ashok Apr 19 '17 at 11:52
$_POST['qurum1'] gets values from checkbox qurum1[], so $qurum1 is like 1|2|3... – Jabbar Guliyev Apr 19 '17 at 11:57
@JabbarGuliyev is $qurum1 a list of all id's? – Jens Apr 19 '17 at 12:03
@Jens $id is different and has 1 value of the post (for ex. $id = 21 and $qurum1 = 1|2|3). The table test has its own id,which has auto_increment. test table colunms is id(auto_increment), data_id(21), col2(1|2|3) – Jabbar Guliyev Apr 19 '17 at 12:09
I have edited the code. I hope, that is the one you looking for.. – Ashok Apr 19 '17 at 12:10
@JabbarGuliyev If i understand you in the right way you store values as "cvs". Which is no good idea – Jens Apr 19 '17 at 12:11
@Ashok, no, because $id already have a value... – Jabbar Guliyev Apr 19 '17 at 12:11
@Jens what do you offer? – Jabbar Guliyev Apr 19 '17 at 12:13
Please just print the content whatever that you got in $qurum1 and $id. (all the from your code) – Ashok Apr 19 '17 at 12:17
@JabbarGuliyev normalize your table – Jens Apr 19 '17 at 12:19

score -3 · Accepted Answer · edited Apr 19 '17 at 11:16

-3

You need to add the MySQL query inside the foreach() function, as well:

foreach ($qurum as $value) {
    $query2 = "INSERT INTO test (data_id, col2) VALUES ($id, $value)";
    mysqlExecute($query2);
}

Note that mysqlExecute() does not exist, you need to use your own function to execute the query.

Also note that executing SQL statements in a loop is not recommended because it slows down performance when executing multiple queries. If your web page does not have too much load or you're just practicing it's fine either way.

edited Apr 19 '17 at 11:16

boroboris

1,548
1
19
32

answered Apr 19 '17 at 11:06

Ciprian

872
1
10
30

why does this answer have 2 downvotes? – boroboris Apr 19 '17 at 11:08
2

Someone didn't like my solution. It's not correct from a performance point of view, but it answers the OP's question. This is not a matter of opinion, it's a matter of answering a question. – Ciprian Apr 19 '17 at 11:11
1

OP provided the code. OP's loop is wrong. – Rotimi Apr 19 '17 at 11:12
It is wrong, he needed the query execution function. This answers his question. I would have used a different structure for this, but I don't know the OP's context. I don't think the downvotes are justified. – Ciprian Apr 19 '17 at 11:15
1

yeah @Ciprian your solution would fix OP's problem – Rotimi Apr 19 '17 at 11:15
@Jens it is not. The code is correct. $id and $value will be recognized as PHP variables and correctly inserted – boroboris Apr 19 '17 at 11:15
1

@boroboris I do not think so, it means that the id is same for all records – Jens Apr 19 '17 at 11:17
@Jens Are you out of mind, code is correct. He just focusing on the error. why are you just looking at syntax problem? its all about solution. – Davinder Kumar Apr 19 '17 at 11:17
One has to wonder how OP plans to deal with the ID variable. Is it the same id value? – Rotimi Apr 19 '17 at 11:17
I think a permanent solution would be to have like a generic insert function that takes a key value array. That way you can throw the whole array into the function and it saves them. – Rotimi Apr 19 '17 at 11:21
Could you write, please? – Jabbar Guliyev Apr 19 '17 at 11:53
I did like @Ciprian said – Jabbar Guliyev Apr 19 '17 at 12:23
@JabbarGuliyev If you're happy with the result, you can mark it as the accepted answer (and/or upvote it). – Ciprian Apr 19 '17 at 12:24
@Ciprian I have already done it – Jabbar Guliyev Apr 19 '17 at 12:41
@JabbarGuliyev Cheers! – Ciprian Apr 19 '17 at 13:37
So many downvotes for an accepted answer. What's your reasoning? Why don't you add a comment? – Ciprian Apr 20 '17 at 09:27

How to insert to a database with foreach?

2 Answers2