Replacing text breaking radio button?

Asked Apr 21 '17 at 18:25

Active Apr 21 '17 at 20:30

Viewed 62 times

http://www.christmascentral.com/giftcertificates.php

I am attempting to change the text for the radio button options. When running the following script on my page, the text gets replaced fine, but now the radio button can't be selected? The html looks to be exactly the same, other than the text being changed.

<script type="text/javascript">

function ChangeLabels() {
    var elements = document.getElementsByTagName('label');
    for (var i=0; i<elements.length; i++) {
        console.log(elements[i].innerHTML);

        var re = new RegExp(' Birthday');
        if (re.test(elements[i].innerHTML)) {
            elements[i].innerHTML = elements[i].innerHTML.replace(' Birthday', ' Test')
        }  
    }
}

$(document).ready(function(){
    ChangeLabels();
});

</script>

edited Apr 21 '17 at 20:30

Martin Adámek

16,771
5
45
64

asked Apr 21 '17 at 18:25

user2278829

Gah, the mix of jQuery and non-jQuery operations here makes me twitch. `getElementsByTagName(...)` -> `$(...)`, `element.innerHTML` -> `$(element).html()` etc. – Draco18s no longer trusts SE Apr 21 '17 at 18:28
You have to change textContent rather then innerHTML. Have a look http://stackoverflow.com/questions/21311299/nodevalue-vs-innerhtml-and-textcontent-how-to-choose – Ilya Zinkevych Apr 21 '17 at 18:33
Do you have some scripts for radio elements on this site? It seems you need to reinitialize it – Christian Esperar Apr 21 '17 at 18:50
@IlyaZinkevych Changing textContent gets rid of the radio button altogether unfortunately. – user2278829 Apr 21 '17 at 18:58
show your HTML, or create a fiddle to replicate the problem. – andi Apr 21 '17 at 20:30

Replacing text breaking radio button?

0 Answers0