RecyclerView blocking ui thread during updates

Question

There are more than 200 items in my list. RecyclerView is updated regularly (Every 10 seconds) . RecyclerView blocking ui thread for few seconds during updates. I'm using notifyDataSetChanged method for refresh recyclerview. Is there another way to prevent freezing ? By the way I don't want use pagination.

This method run every 10 seconds :

public void refreshAssetList(List<Asset> newAssetList){
     recyclerViewAdapter.setAssetList(newAssetList);
     recyclerViewAdapter.notifyDataSetChanged();
}

RecyclerViewAdapter class :

public class AssetListRecyclerViewAdapter extends RecyclerView.Adapter<AssetListRecyclerViewAdapter.BaseViewHolder> {

    private List<Asset> assetList;
    Context context;

    public AssetListRecyclerViewAdapter(List<Asset> assetList, Context context) {
        this.assetList = assetList;
        this.context = context;
    }

    public void setAssetList(List<Asset> assetList) {
        this.assetList = assetList;
    }

    @Override
    public BaseViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
            View itemLayoutView = LayoutInflater.from(parent.getContext()).inflate(R.layout.list_item_asset, null);
            return new DetailViewHolder(itemLayoutView);
    }

    @Override
    public void onBindViewHolder(BaseViewHolder holder, int position) {
        Asset asset = assetList.get(position);
        Last last = asset.getLast();
        if (holder.getItemViewType() == TYPE_DETAIL) {
            DetailViewHolder mHolder = (DetailViewHolder) holder;
            mHolder.dateTextView.setText(last.getDate());
            mHolder.brandTextView.setText(asset.getMc());
        }
    }

     class DetailViewHolder extends BaseViewHolder {

        @Bind(R.id.brandTextV)
        TextView brandTextView;
        @Bind(R.id.dateTextV)
        TextView dateTextView;

         DetailViewHolder(View itemLayoutView) {
            super(itemLayoutView);
            ButterKnife.bind(this, itemLayoutView);
        }
    }

}

can you put the code of this method in your question ? AssetListHelper.getAssetListByQuery(query, context); — Luiz Fernando Salvaterra, Apr 25 '17 at 10:51
yes assetList is a global variable. And getAssetListByQuery method is unimportant. I am updating the question. — yusufonderd, Apr 25 '17 at 10:53
Why you need to refresh all item any specific requirement??!! — Ram Prakash Bhat, Apr 25 '17 at 11:06

score 6 · Accepted Answer · answered Apr 25 '17 at 12:11

6

You do not need to call notifyDataSetChanged, it's an expensive operation your whole RecyclerView will completely redraw, rebind etc.

As the doc says:

This event does not specify what about the data set has changed, forcing any observers to assume that all existing items and structure may no longer be valid. LayoutManagers will be forced to fully rebind and relayout all visible views.

All you need to do is loop through every position and if needed update desired item otherwise do nothing or skip.

What you should do:

As you are updating your whole view first you need to compare your (visible) adapter's List<Asset> with new List<Asset> and retrieve only those items which you need to be update, once you have the list loop through updated list and update your adapter's view by using viewAdapter.notifyItemChanged(position).

answered Apr 25 '17 at 12:11

Haris Qurashi

2,104
1
13
28

Thanks for the detailed answer. After some research I found DiffUtil class for detecting changed items. Even so freeze still exist. Before DiffUtil 4 seconds freeze. Now after usage DiffUtil class : freeze time is 2 second. Less freezing for 2 seconds. DiffUtil sample project : https://github.com/mrmike/DiffUtil-sample – yusufonderd Apr 25 '17 at 13:03
Its good you found the main reason of your problem, Now get start and end visible item positions and update only those items, do nothing with the rest view items and just update your adapter's `List` with new one. In this case you will only update visible items and once you scroll up or down your view will update according to updated list – Haris Qurashi Apr 25 '17 at 13:33

score 0 · Answer 2 · answered Apr 25 '17 at 11:18

0

Perform the action to update the adapter as:

public void refreshAssetList(List<Asset> newAssetList){
        getActivity().runOnUiThread(new Runnable() {
            @Override
            public void run() {
                recyclerViewAdapter.setAssetList(newAssetList);
                recyclerViewAdapter.notifyDataSetChanged();
            }
        }); 
}

answered Apr 25 '17 at 11:18

Sanjog Shrestha

417
9
16

1

No any changing. Freezing continues. – yusufonderd Apr 25 '17 at 11:27
Is the problem persistent if you do not set and update the adapter? Check once. – Sanjog Shrestha Apr 25 '17 at 11:34
That means, this is not causing the freezing. Check if the webservice you are consuming is causing. – Sanjog Shrestha Apr 25 '17 at 11:40
No freeze when remove notifyDataSetChanged method . So my problem is not related web services – yusufonderd Apr 25 '17 at 11:43
Let us [continue this discussion in chat](http://chat.stackoverflow.com/rooms/142605/discussion-between-sanjog-shrestha-and-yusufonder). – Sanjog Shrestha Apr 25 '17 at 11:44

score 0 · Answer 3 · answered Apr 26 '17 at 09:21

After some research I found DiffUtil class for updating list.

From the documentation :

DiffUtil is a utility class that can calculate the difference between two lists and output a list of update operations that converts the first list into the second one.

DiffUtil needs new list and old list. It only updates changing items in list. I created AssetDiffUtil class as below :

public class AssetDiffUtil extends DiffUtil.Callback {

    private final List<Asset> oldList;
    private final List<Asset> newList;

    public AssetDiffUtil(List<Asset> oldList, List<Asset> newList) {
        this.oldList = oldList;
        this.newList = newList;
    }

    @Override
    public int getOldListSize() {
        return oldList.size();
    }

    @Override
    public int getNewListSize() {
        return newList.size();
    }

    @Override
    public boolean areItemsTheSame(int oldItemPosition, int newItemPosition) {
        return oldList.get(oldItemPosition).getId() == newList.get(newItemPosition).getId();
    }

    @Override
    public boolean areContentsTheSame(int oldItemPosition, int newItemPosition) {
        final Last oldItem = oldList.get(oldItemPosition).getLast();
        final Last newItem = newList.get(newItemPosition).getLast();
        return oldItem.getDate().equals(newItem.getDate());
    }

    @Nullable
    @Override
    public Object getChangePayload(int oldItemPosition, int newItemPosition) {
        // Implement method if you're going to use ItemAnimator
        return super.getChangePayload(oldItemPosition, newItemPosition);
    }
}

Then I added swapItems method for refreshing list in AssetListRecyclerViewAdapter class.

  public void swapItems(List<Asset> newAssetList) {
        final DiffUtil.DiffResult diffResult = DiffUtil.calculateDiff(new AssetDiffUtil(this.assetList, newAssetList));
        this.assetList.clear();
        this.assetList.addAll(newAssetList);
        diffResult.dispatchUpdatesTo(this);
    }

That's it. But my problem still exist. Before using DiffUtil freezing time 4 seconds . Now, after using DiffUtil freezing time is 2 seconds. Unfortunately this is not a definitive solution for my problem.

score 0 · Answer 4 · answered Feb 23 '21 at 09:20

use notifyItemRangeChanged instead of notifyDataSetChanged , also sometimes when using progress bars libraries like SpinKitView it increases the freezing time

loadMoreProgress.visibility = View.VISIBLE
            homeViewModel.latestBars.observe(viewLifecycleOwner, Observer {
                latestBarTests.addAll(it)
                latestBarsAdapter.notifyItemRangeChanged(
                    latestBarTests.size - it.size,
                    latestBarTests.size
                )
            })

RecyclerView blocking ui thread during updates

4 Answers4

Linked