Recursive UITableViewCell button Action

Question

I'm able to generate a UITableView and a UITableViewCell however my action is not working properly. My use case is similiar to this video

I was using this question as a reference and was uncesscessful

What am I missing? Something swift 3 related?

class ViewController: UIViewController, UITableViewDelegate, UITableViewDataSource {

    @IBOutlet weak var tableView: UITableView!

    var categories = ["foo", "bar"]

    func logAction(sender: UIButton!){
        print("HIT BUTTON YO")
    }

    public func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        return self.categories.count
    }

    public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {      
        let cell:CustomCell = tableView.dequeueReusableCell(withIdentifier: "categories", for: indexPath) as! CustomCell
        cell.label.text = categories[indexPath.row]
        let button = cell.button
        button?.tag = indexPath.row
        button?.addTarget(self, action: #selector(self.logAction), for: .touchUpInside)
        return(cell)
    }
}


class CustomCell: UITableViewCell {

    @IBOutlet weak var button: UIButton!
    @IBOutlet weak var label: UILabel!


    override func awakeFromNib() {
        super.awakeFromNib()
    }

    override func setSelected(_ selected: Bool, animated: Bool) {
        super.setSelected(selected, animated: animated)
        //Configure view for selected state
    } 
}

it doesnt crash at all....When I click on the button on my table, nothing happens....have also tried `tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath)` — Lucas Crostarosa, Apr 26 '17 at 18:06

score 2 · Answer 1 · answered Apr 26 '17 at 18:07

2

There is a smarter way to handle a button action in a custom cell.

In the custom cell create a callback closure with no parameter / no return value and an IBAction connected to the button. In the action call the callback

class CustomCell: UITableViewCell {

    @IBOutlet weak var button: UIButton!
    @IBOutlet weak var label: UILabel!

    var callback : (()->())?

    @IBAction func logAction(_ sender : UIButton) {
        callback?()
    }
}

In cellForRow assign a closure to the callback, the index path is captured.

public func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
    let cell = tableView.dequeueReusableCell(withIdentifier: "categories", for: indexPath) as! CustomCell
    cell.label.text = categories[indexPath.row]
    cell.callback = {
        print("Button pressed", indexPath)
    }
    return cell
}

Note: return is not a function (no parentheses).

answered Apr 26 '17 at 18:07

vadian

274,689
30
353
361

No response from the console with that, it does look clean though – Lucas Crostarosa Apr 26 '17 at 18:18
Is the class of the custom cell set to `CustomCell` in Interface Builder? – vadian Apr 26 '17 at 18:20
Yes it is. Not sure what else it could be – Lucas Crostarosa Apr 26 '17 at 18:30
1

Works like a charm for me... maybe start fresh? – DonMag Apr 26 '17 at 19:11

score 0 · Answer 2 · answered Apr 26 '17 at 18:07

0

Try accessing the cell's button directly. Instead of

let button = cell.button
button?.tag = indexPath.row
button?.addTarget(self, action: #selector(self.logAction), for: .touchUpInside)

Set the properties on the button directly.

cell.button.tag = indexPath.row
cell.button.addTarget(self, action: #selector(self.logAction), for: .touchUpInside)

answered Apr 26 '17 at 18:07

naturaln0va

755
6
8

No response from the console with that – Lucas Crostarosa Apr 26 '17 at 18:18
it looks like your "#selector(self.logAction)" could be wrong. It should look like "logAction(sender:)". – naturaln0va Apr 26 '17 at 18:30

score 0 · Answer 3 · answered Apr 27 '17 at 01:47

0

yea so I just deleted the view controller and remade and it works now ¯_(ツ)_/¯

answered Apr 27 '17 at 01:47

Lucas Crostarosa

1,192
6
13
26

Recursive UITableViewCell button Action

3 Answers3