converting structure to class

Question

I'm trying to convert structures to class, but I'm not completely sure of what exactly goes in a class header file. I've made some changes, can someone tell me what else I should change? Thank you!

structure:

enter code here: 
#ifndef TIME_H
#define TIME_H

#include <iostream>

struct Time {
int hours, minutes, seconds;
};

void init(Time &t, int hours, int minutes, int seconds);
void normalize(Time &t);
Time operator +(const Time &t1, const Time &t2);
Time &operator +=(Time &t1, const Time &t2);
Time operator -(const Time &t1, const Time &t2);
Time &operator -=(Time &t1, const Time &t2);
bool operator ==(const Time &t1, const Time &t2);

std::ostream &operator <<(std::ostream &os, const Time &t);
std::istream &operator >>(std::istream &is, Time &t);

#endif

class:

#define TIME_H

#include <iostream>

class Time {


public:
void init(Time &t, int hours, int minutes, int seconds);
void normalize(Time &t);
Time operator +(const Time &t1, const Time &t2);
Time &operator +=(Time &t1,const Time &t2);
Time operator -(const Time &t1, const Time &t2);
Time &operator -=(Time &t1, const Time &t2);
bool operator ==(const Time &t1, const Time &t2);
std::ostream &operator <<(std::ostream &os, const Time &t);
std::istream &operator >>(std::istream &is, Time &t);
private: 
int hours, minutes, seconds;

};

#endif

In C++ struct is the same as class, only difference - by default in struct is public and in class - private — Anton, Apr 29 '17 at 18:17
Does the *real* code *work* ? If so, this question probably doesn't belong here, and should be on [code review](https://codereview.stackexchange.com/) — WhozCraig, Apr 29 '17 at 18:17
http://stackoverflow.com/questions/92859/what-are-the-differences-between-struct-and-class-in-c. Read it first. — Cengiz Kandemir, Apr 29 '17 at 18:18
You shuold rename init to Time (it's constructor), in some cases you need to add ~Time() (destructor) — Anton, Apr 29 '17 at 18:18
@WhozCraig Read https://codereview.meta.stackexchange.com/questions/5777/a-guide-to-code-review-for-stack-overflow-users and see if you think this question really meets their criteria. — Barmar, Apr 29 '17 at 19:01

The Techel · Answer 1 · 2017-04-29T18:22:08.317

0

You should always use the constructor and destructor instead of 'init'- or 'close'-methods: Time(int hrs, int secs, int mins). Provide a default constructor too which initializes the members to some default values. Consider defining them as unisgned int, since they cannot become negative. Further, include <iosfwd> instead of <iostream> if you just want acces to the stream interfaces.

edited Apr 29 '17 at 18:22

answered Apr 29 '17 at 18:17

The Techel

918
8
13

so it would be: void Time( int hours, int minutes, int seconds); – adin Apr 29 '17 at 18:20
thanks, is there anything else i should be changing? – adin Apr 29 '17 at 18:32

converting structure to class

1 Answers1