mongoose finds but doesn't remove

Question

I am finding any document that matches my condition and I want to remove those docs.

MyModle.find({writer: req.body.id}, function(err, docs){
                if (err){ return console.log(err)}
                if (!docs || !Array.isArray(docs) || docs.length === 0){
                    return console.log('no docs found')}
                docs.forEach( function (doc) {
                    doc.remove();
                    console.log("Removed book with ID ",doc._id, "by writer ", req.body.id);
                });
            });

My console is printing the message as if the document was removed, but it is still in the collection. What is wrong here?

score 1 · Accepted Answer · edited May 23 '17 at 12:10

1

As stated in the documentation for remove, the deletion is performed only if you either:

pass a callback function: doc.remove(function() { console.log('removed!'); });
or call exec: doc.remove().exec()

See also this question

To fix your code, you can replace:

doc.remove();
console.log("Removed book with ID ",doc._id, "by writer ", req.body.id)

with

doc.remove(function() {
    console.log("Removed book with ID ",doc._id, "by writer ", req.body.id)
});

edited May 23 '17 at 12:10

Community

1
1

answered May 06 '17 at 23:16

Aurélien Gasser

3,043
1
20
25

which part of my code in the example should I modify to get this? could you please help? – cplus May 06 '17 at 23:18
i tried your solution but still they are in the collection. what is missing here? – cplus May 06 '17 at 23:23
@cplus Have you tried printing the error? `doc.remove(function(err) { console.log(err) })` – Aurélien Gasser May 06 '17 at 23:39

mongoose finds but doesn't remove

1 Answers1